Closed
Bug 1432508
Opened 6 years ago
Closed 6 years ago
Support default_locale in static theme manifests
Categories
(WebExtensions :: Themes, enhancement, P5)
WebExtensions
Themes
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file)
- default_locale - update_url should be accepted
Assignee | ||
Comment 1•6 years ago
|
||
I won't add update_url on second thought, since we don't support it for extensions either.
Summary: Accept more properties in static theme manifests → Relax WebExtension theme manifest parsing
Assignee | ||
Comment 2•6 years ago
|
||
I couldn't find anything else than default_locale
Summary: Relax WebExtension theme manifest parsing → Support default_locale in static theme manifests
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8944837 [details] Bug 1432508 - Support default_locale in static theme manifests. https://reviewboard.mozilla.org/r/214994/#review220668 What's the scope here? Is it just localizing manifest fields like name and description? Whatever we're trying to support should have accompanying tests to prevent future regressions.
Attachment #8944837 -
Flags: review?(aswan) → review-
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(ntim.bugs)
Updated•6 years ago
|
Component: WebExtensions: General → WebExtensions: Frontend
Priority: -- → P5
Updated•6 years ago
|
Component: WebExtensions: Frontend → WebExtensions: Themes
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(ntim.bugs)
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8944837 [details] Bug 1432508 - Support default_locale in static theme manifests. https://reviewboard.mozilla.org/r/214994/#review244680 ::: toolkit/components/extensions/schemas/i18n.json:10 (Diff revision 2) > [ > { > "namespace": "manifest", > "types": [ > { > - "$extend": "WebExtensionManifest", > + "$extend": "ManifestBase", I'm not sure we want this. Language packs also use ManifestBase and dictionaries eventually will too and it doesn't seem right for them. There's not a great solution but for now lets just add it directly to ThemeManifest ::: toolkit/mozapps/extensions/test/xpcshell/test_webextension.js:137 (Diff revision 2) > addon.uninstall(); > > await promiseRestartManager(); > }); > > +// Test that default_locale works with WE themes please move this test to test_webextension_theme.js
Attachment #8944837 -
Flags: review?(aswan) → review-
Comment hidden (mozreview-request) |
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8944837 [details] Bug 1432508 - Support default_locale in static theme manifests. https://reviewboard.mozilla.org/r/214994/#review246850 thanks
Attachment #8944837 -
Flags: review?(aswan) → review+
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b74e2721b7f0 Support default_locale in static theme manifests. r=aswan
Comment 10•6 years ago
|
||
Backed out for browser chrome failures on browser_ext_browserAction_theme_icons.js ( Error: Internal error: Type ThemeType not found ) Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b74e2721b7f067a0dd0e44f50f31d339192d3187 Backout: https://hg.mozilla.org/integration/autoland/rev/9d3b1d2dd32e6f606cd590b82032c8bbf0cc8156 Log: https://treeherder.mozilla.org/logviewer.html#?job_id=176517266&repo=autoland&lineNumber=2342
Flags: needinfo?(aswan)
Comment 11•6 years ago
|
||
Also, browser chrome failures on /browser_ext_themes_dynamic_getCurrent.js Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=176517239&repo=autoland&lineNumber=4344
Comment hidden (mozreview-request) |
Comment 14•6 years ago
|
||
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a662fe1cc8ba Support default_locale in static theme manifests. r=aswan
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a662fe1cc8ba
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•