Closed Bug 1432529 Opened 4 years ago Closed 4 years ago

Exit spinEventLoopUntil(...) when canceling out of migrator wizard

Categories

(Firefox :: Migration, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: dthayer, Assigned: dthayer)

References

Details

Attachments

(1 file)

Created as a follow-up for Bug 862127. We spin the event loop in order to wait for async functions to complete when we're in the migrator wizard, but if we cancel the wizard we want to ensure we stop waiting on any of the promises associated with it. Once we do this, we can allow canceling if we're waiting on a promise.
Priority: -- → P3
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Comment on attachment 8951392 [details]
Bug 1432529 - Exit spinEventLoopUntil when canceling migrator

https://reviewboard.mozilla.org/r/220666/#review226858

Nice, thanks!
Attachment #8951392 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d30a1e6932f9
Exit spinEventLoopUntil when canceling migrator r=Gijs
https://hg.mozilla.org/mozilla-central/rev/d30a1e6932f9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.