1432538 - test_screenshot.py loads HTML document with window.openDialog on a ChromeWindow

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

test_screenshot.py in the Mn test suite loads an HTML document with
window.openDialog("test.html", "", "chrome") in chrome context.
Because it is an HTML document it will not fire the "load" or
"DOMContentLoaded" DOM events.

This is not a problem with the way Marionette currently detects
document loads of ChromeWindows (by polling) but will become a
problem once the window tracking refactoring lands [1] because that
uses DOM events to detect document load.

  [1] https://bugzil.la/marionette-window-tracking

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1432538 - Delete chrome viewport screen capture test.

Capturing the viewport of a ChromeWindow does not make sense.
The test loads an HTML document to "get scrollbars", but scrollbars
and indeed HTML documents make no sense in this context.

When window.openDialog is called on a ChromeWindow Marionette also
fails to load the content frame script.

Review commit: https://reviewboard.mozilla.org/r/215318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215318/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8945096 [details]
Bug 1432538 - Delete chrome viewport screen capture test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215318/diff/1-2/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8945096 [details]
Bug 1432538 - Delete chrome viewport screen capture test.

https://reviewboard.mozilla.org/r/215318/#review221190

As discussed on IRC this is not a supported method. So yes, lets get it removed. Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/747fade2a7f2
Delete chrome viewport screen capture test. r=whimboo

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/747fade2a7f2