1432555 - Restore and use existing string extensionControlled.enable for instruction on how to enable extensions

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Francesco Lodolo [:flod]]

https://hg.mozilla.org/mozilla-central/rev/2018c9901076

This changeset from bug 1431428 introduced a new string (extensionControlled.enable2), identical to the existing one, minus the localization comment (also note the wrong reference in the comment)

The part removed is

# Note, this string will be used as raw markup. Avoid characters like <, >, &

We should keep using the existing string, since the previous limitations aren't really affecting current translation
https://transvision.mozfr.org/string/?entity=browser/chrome/browser/preferences/preferences.properties:extensionControlled.enable&repo=gecko_strings

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1432555 - Restore and use existing string extensionControlled.enable for instruction on how to enable extensions

Review commit: https://reviewboard.mozilla.org/r/214960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214960/

Comment 2

[Ton [:Tonnes]]

(Landing here after noticing the wrong reference and similarity)

> extensionControlled.enable2 = To enable the extension go to %1$S Add-ons in the %2$S menu.

Additionally, what’s the criteria for using a comma (or not) between "extension" and "go"? If needed, the new entity may come in handy. Or not, as it would affect en-US/en-GB only.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Ton from comment #2)
> (Landing here after noticing the wrong reference and similarity)
> 
> > extensionControlled.enable2 = To enable the extension go to %1$S Add-ons in the %2$S menu.
> 
> Additionally, what’s the criteria for using a comma (or not) between
> "extension" and "go"? If needed, the new entity may come in handy. Or not,
> as it would affect en-US/en-GB only.

By looking at other strings, it probably should have a comma
https://transvision.mozfr.org/?recherche=To+&repo=gecko_strings&sourcelocale=en-US&locale=it&search_type=strings_entities&case_sensitive=case_sensitive

Having said that, until this lands, we can't expose other strings for localization, so I'd prefer to not get blocked by getting feedback from UX about an existing string. I'd suggest to use a different bug for that, and set dependency to bug 1403751.

In case, that kind of change would definitely land without a new string ID.

Comment 4

[:Gijs (he/him)]

I used a new string because previously, if a localization used:

"Blah blah > blah blah" that would be rendered "blah blah > blah blah"

Likewise, real HTML would show up.

That is no longer the case. I assumed this would require a new string to avoid HTML escape gunk showing up for locales that used this. Is that not the case?

Comment 5

[Axel Hecht [:Pike]]

It would be, but there's no locale that's actually using those chars, so we're cool.

https://dxr.mozilla.org/l10n-central/search?q=extensionControlled.enable&redirect=false

Comment 6

[:Gijs (he/him)]

Comment on attachment 8944807 [details]
Bug 1432555 - Restore and use existing string extensionControlled.enable for instruction on how to enable extensions

https://reviewboard.mozilla.org/r/214960/#review220646

rs=me

Sorry for not doing the due diligence in terms of checking l10n-central. :-(

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a1df6045d3c
Restore and use existing string extensionControlled.enable for instruction on how to enable extensions r=Gijs

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7a1df6045d3c

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> Sorry for not doing the due diligence in terms of checking l10n-central. :-(

No problem. In general, I don't think I've ever seen locales adding HTML to strings, because you never know where a string shows up without looking at the code. The edge case was &, but we're good.

P.S. I put a link in comment 0 with all current translations (we ship all branches from one repository, l10n-central, which maps to gecko-strings on Transvision)
https://transvision.mozfr.org/string/?entity=browser/chrome/browser/preferences/preferences.properties:extensionControlled.enable&repo=gecko_strings