1432563 - Download rustfmt-preview from the rust repackage.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

This will be needed for bug 1432153.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1432563: Fetch rustfmt when repackaging rust.

I tested this on automation and the build went on, though I couldn't test
the bindgen output because the build right now is busted on one dependent crate
with rust beta, which is the first toolchain that has this package, and will go
to release shortly.

This should work though! If I need more changes I'll adjust them in bug 1432153.

You can test the repackage manually with repack_rust.py --toolchain beta, for
example.

Review commit: https://reviewboard.mozilla.org/r/214964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214964/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8944813 [details]
Bug 1432563: Fetch rustfmt when repackaging rust.

https://reviewboard.mozilla.org/r/214964/#review221316

::: taskcluster/scripts/misc/repack_rust.py:234
(Diff revision 1)
>          info = fetch_package(manifest, 'rust-std', target)
>          stds.append(info)
>      return stds
>  
>  
> +def fetch_extension(manifest, pkg, host):

Maybe call this `fetch_optional` since it would work for any package, not just extensions?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8944813 [details]
Bug 1432563: Fetch rustfmt when repackaging rust.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214964/diff/1-2/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8944813 [details]
Bug 1432563: Fetch rustfmt when repackaging rust.

https://reviewboard.mozilla.org/r/214964/#review221316

> Maybe call this `fetch_optional` since it would work for any package, not just extensions?

WFM :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97ba0ca85c5b
Fetch rustfmt when repackaging rust. r=rillian

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/97ba0ca85c5b