1432580 - Unresponsive script waring appears in some tabs in some windows

Status: RESOLVED WONTFIX

(Core :: XPConnect, defect)

Description

[Markus Jaritz [:markus] (UX)]

Attachment: Unresponsive-script-warning-in-some-tabs.gif

An Unresponsive Script Warning surfaced in some windows, and within the main window in some tabs, but not in others. I could not identify any reason for it to appear in some of those places, but not in others. (see attached gif)
(I assume this has to do with which process is affected)

Expected Result: The unresponsive script warning only appears on the affected tab, bringing that tab to the foreground.
Or: it shows up everywhere.

Whatever path taken, I think the purpose should be to make the user aware of something slowing down their machine, and give them an option to do something about it.


Observed on Firefox Nightly 60.0a1 (2018-01-23) (64-bit) on Windows 10.

Comment 1

[Jens Stutte [:jstutte]]

Are you still seeing this?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Note that the specific string has the identifier "nonspecific_tab":

processHang.nonspecific_tab.label = A web page is slowing down %1$S. To speed up your browser, stop that page.

It's used here.

Comment 3

[Markus Jaritz [:markus] (UX)]

I do not know how to trigger that message and therefore can't test if I would still see this behaviour.

Comment 4

[Jens Stutte [:jstutte]]

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #2)

Note that the specific string has the identifier "nonspecific_tab":

processHang.nonspecific_tab.label = A web page is slowing down %1$S. To speed up your browser, stop that page.

It's used here.

That logic seems to have been overhauled largely in bug 1694229 in the meantime. Moving it to that component and clearing severity for triage, maybe someone there knows if this has been addressed.

Comment 5

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Jens Stutte [:jstutte] from comment #4)

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #2)

Note that the specific string has the identifier "nonspecific_tab":

processHang.nonspecific_tab.label = A web page is slowing down %1$S. To speed up your browser, stop that page.

It's used here.

That logic seems to have been overhauled largely in bug 1694229 in the meantime. Moving it to that component and clearing severity for triage, maybe someone there knows if this has been addressed.

Hi Alex,
Can you help us verify if this issue is fixed along with Bug 1694229? Thank you.

Comment 6

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Request Needinfo for comment 5, thank.

Comment 7

[Alex Thayer [:alexical] (she/her)]

I mean, yeah basically we are showing the notification if the process that we're trying to use to display a given tab is hung, regardless of whether that specific tab caused the hang or not. Honestly we could get really specific with the wording to point this out, but imo this is just not a priority. This is kind of different with the new logic introduced by bug 1694229, because we won't show the notification unless the user interacts with the tab, but I don't think this would qualify as fixed.

That being said, I don't think this is really worth addressing. We simply don't want to show a notification on all tabs if one content process is hung, and we can't just show nothing if one tab is hung because of a hanging script in another tab in the same process. So that leaves us with the option of making a long complicated message trying to explain precisely what is happening, but I doubt users will care to take the time to understand the nuance, so I think we're best with this the way it is. It's also less of an issue now with fission.

Comment 8

[Sean Feng [:sefeng211]]

Yeah, sounds good Alex. That being said, I think we should just resolve this bug as WONTFIX.