1432602 - Add nsIFileURLMutator.setFile()

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1432602 - Add nsIFileURLMutator.setFile()

Review commit: https://reviewboard.mozilla.org/r/215010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215010/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8944855 [details]
Bug 1432602 - Add nsIFileURLMutator.setFile()

https://reviewboard.mozilla.org/r/215010/#review220630


Static analysis found 1 defect in this patch.
 - 1 defect found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: netwerk/protocol/res/SubstitutingProtocolHandler.h:126
(Diff revision 1)
>  // SubstitutingURL : overrides nsStandardURL::GetFile to provide nsIFile resolution
>  class SubstitutingURL : public nsStandardURL
>  {
>  public:
>    SubstitutingURL() : nsStandardURL(true) {}
> +  SubstitutingURL(bool aSupportsFileURL) : nsStandardURL(true) { MOZ_ASSERT(aSupportsFileURL); }

Error: Bad implicit conversion constructor for 'substitutingurl' [clang-tidy: mozilla-implicit-constructor]

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8944855 [details]
Bug 1432602 - Add nsIFileURLMutator.setFile()

https://reviewboard.mozilla.org/r/215010/#review220936

::: netwerk/base/nsIFileURL.idl:26
(Diff revision 1)
>       *
>       *  - Getter returns a reference to an immutable object.  Callers must clone
>       *    before attempting to modify the returned nsIFile object.  NOTE: this
>       *    constraint might not be enforced at runtime, so beware!!
> -     *
> +     */
> +    attribute nsIFile file;

where do you plan to turn this to r/o?

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8944855 [details]
Bug 1432602 - Add nsIFileURLMutator.setFile()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215010/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a20fbbe7b948
Add nsIFileURLMutator.setFile() r=mayhemer

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a20fbbe7b948