Add nsIFileURLMutator.setFile()

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: valentin.gosu, Assigned: valentin.gosu)

Tracking

Trunk
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

No description provided.
Comment on attachment 8944855 [details]
Bug 1432602 - Add nsIFileURLMutator.setFile()

https://reviewboard.mozilla.org/r/215010/#review220630


Static analysis found 1 defect in this patch.
 - 1 defect found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: netwerk/protocol/res/SubstitutingProtocolHandler.h:126
(Diff revision 1)
>  // SubstitutingURL : overrides nsStandardURL::GetFile to provide nsIFile resolution
>  class SubstitutingURL : public nsStandardURL
>  {
>  public:
>    SubstitutingURL() : nsStandardURL(true) {}
> +  SubstitutingURL(bool aSupportsFileURL) : nsStandardURL(true) { MOZ_ASSERT(aSupportsFileURL); }

Error: Bad implicit conversion constructor for 'substitutingurl' [clang-tidy: mozilla-implicit-constructor]
Comment on attachment 8944855 [details]
Bug 1432602 - Add nsIFileURLMutator.setFile()

https://reviewboard.mozilla.org/r/215010/#review220936

::: netwerk/base/nsIFileURL.idl:26
(Diff revision 1)
>       *
>       *  - Getter returns a reference to an immutable object.  Callers must clone
>       *    before attempting to modify the returned nsIFile object.  NOTE: this
>       *    constraint might not be enforced at runtime, so beware!!
> -     *
> +     */
> +    attribute nsIFile file;

where do you plan to turn this to r/o?
Attachment #8944855 - Flags: review?(honzab.moz) → review+
Depends on: 1434766
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a20fbbe7b948
Add nsIFileURLMutator.setFile() r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/a20fbbe7b948
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1435772
Blocks: 1436589
You need to log in before you can comment on or make changes to this bug.