Closed
Bug 1432672
Opened 7 years ago
Closed 7 years ago
Remove sidebar preferences and have gear open about:preferences
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: ursula)
References
(Blocks 1 open bug)
Details
(Whiteboard: [blocked])
Attachments
(1 file)
No description provided.
Updated•7 years ago
|
Whiteboard: [AS60MVP]
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → edilee
Updated•7 years ago
|
Iteration: 60.2 - Feb 12 → 60.3 - Feb 26
Updated•7 years ago
|
Priority: P2 → P1
Reporter | ||
Updated•7 years ago
|
Iteration: 60.3 - Feb 26 → 60.4 - Mar 12
Whiteboard: [AS60MVP] → [blocked][AS60MVP]
Updated•7 years ago
|
Assignee: edilee → khudson
Updated•7 years ago
|
Assignee: khudson → usarracini
Comment 1•7 years ago
|
||
Do you mind picking this one up :ursula? Tim requested that we not delete the code yet in case we need to switch back to the old prefs pane after some time in Beta, so maybe let's split the deletion into a different bug post-60. Alternatively, we could just back out the patch... but I think leaving it in will be an easier/smaller patch to uplift.
Another thing to note is that we should still be sending the "SETTINGS_OPEN" event when it is clicked but we don't have to send "SETTINGS_CLOSED".
Reporter | ||
Comment 2•7 years ago
|
||
I was going to check Prefs["feeds.aboutpreferences"] to OnlyToMain some action. Note that an OPEN_LINK of about:preferences won't work because we no longer allow link navigation from null principal. Although something from main can handle SETTINGS_OPEN to navigate specially.
Updated•7 years ago
|
Iteration: 60.4 - Mar 12 → 61.1 - Mar 26
Updated•7 years ago
|
Priority: P1 → P3
Updated•7 years ago
|
Whiteboard: [blocked][AS60MVP] → [blocked]
Updated•7 years ago
|
Priority: P3 → P1
Reporter | ||
Updated•7 years ago
|
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/4c9c1792b897fe247b89fb4649444277f674fcde
Fix Bug 1432672 - Remove sidebar Preferences and have gear open about:preferences
https://github.com/mozilla/activity-stream/commit/9b4970b4ab57e4b78ca614a14d8d105fc4a59b2e
Merge pull request #4041 from sarracini/bug_1432672
Fix Bug 1432672 - Remove sidebar preferences and have gear open about:preferences
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•7 years ago
|
||
status-firefox61:
--- → fixed
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•