Remove sidebar preferences and have gear open about:preferences

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: Mardak, Assigned: ursula)

Tracking

(Blocks 1 bug)

Trunk
Firefox 61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 wontfix, firefox61 fixed)

Details

(Whiteboard: [blocked])

Attachments

(1 attachment)

Reporter

Description

Last year
No description provided.
Reporter

Updated

Last year
Blocks: 1411569
Reporter

Updated

Last year
Blocks: 1399428
Whiteboard: [AS60MVP]
Reporter

Updated

Last year
Blocks: 1396564, 1417072
Reporter

Updated

Last year
Blocks: 1425500
Reporter

Updated

Last year
Blocks: 1421440
Reporter

Updated

Last year
Assignee: nobody → edilee
Iteration: 60.2 - Feb 12 → 60.3 - Feb 26
Priority: P2 → P1
Reporter

Updated

Last year
Iteration: 60.3 - Feb 26 → 60.4 - Mar 12
Whiteboard: [AS60MVP] → [blocked][AS60MVP]
Assignee: edilee → khudson
Assignee: khudson → usarracini
Do you mind picking this one up :ursula? Tim requested that we not delete the code yet in case we need to switch back to the old prefs pane after some time in Beta, so maybe let's split the deletion into a different bug post-60. Alternatively, we could just back out the patch... but I think leaving it in will be an easier/smaller patch to uplift.

Another thing to note is that we should still be sending the "SETTINGS_OPEN" event when it is clicked but we don't have to send "SETTINGS_CLOSED".
Reporter

Comment 2

Last year
I was going to check Prefs["feeds.aboutpreferences"] to OnlyToMain some action. Note that an OPEN_LINK of about:preferences won't work because we no longer allow link navigation from null principal. Although something from main can handle SETTINGS_OPEN to navigate specially.
Iteration: 60.4 - Mar 12 → 61.1 - Mar 26
Priority: P1 → P3
Whiteboard: [blocked][AS60MVP] → [blocked]
Priority: P3 → P1
Reporter

Updated

Last year
Blocks: 1408133

Comment 4

Last year
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4c9c1792b897fe247b89fb4649444277f674fcde
Fix Bug 1432672 - Remove sidebar Preferences and have gear open about:preferences

https://github.com/mozilla/activity-stream/commit/9b4970b4ab57e4b78ca614a14d8d105fc4a59b2e
Merge pull request #4041 from sarracini/bug_1432672

Fix Bug 1432672 - Remove sidebar preferences and have gear open about:preferences

Updated

Last year
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Reporter

Updated

Last year
Blocks: 1446053
Reporter

Comment 5

Last year
https://hg.mozilla.org/mozilla-central/rev/70fe801fb934
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.