1432683 - TypeError: __getnewargs__ should return a tuple, not 'unicode' in testing/mochitest/mach_commands.py

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Matthew N. [:MattN]]

Attachment: Full mach output

In order to workaround bug 1132044 not getting fixed, I added the following to my machrc file:
> [test]
> format = mach

This break `./mach test --verify` and `./mach mochitest --verify` with the following error:
> TypeError: __getnewargs__ should return a tuple, not 'unicode'
> 
> File "/mozilla-central/testing/mochitest/mach_commands.py", line 411, in run_mochitest_general
>   **harness_args)

The full output is attached.

Comment 1

[Andrew Halberstadt [:ahal]]

This is happening because when 'mach_commands.py' creates the logger (as opposed to the mochitest harness), the Logger instance is stored in the options dict. Verify mode will then try to deepcopy that instance which fails.

The logger args are only used when instantiating a new mochitest runner anyway, so we might as well delete them from the options object after we're done with them.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1432683 - [mochitest] Remove 'log' argument from the main options object,

This was causing problems for the test-verify mode. Sometimes the 'log' option
can contain a class instance and then 'verify' attempts to deepcopy that (which
fails).

Since the 'log' option is only used in the Mochitest constructor, it's probably
simplest to just remove it from the main options object right at the start.

Review commit: https://reviewboard.mozilla.org/r/227058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227058/

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 8958216 [details]
Bug 1432683 - [mochitest] Remove 'log' argument from the main options object,

https://reviewboard.mozilla.org/r/227058/#review232936

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be970e4eb5e6
[mochitest] Remove 'log' argument from the main options object, r=gbrown

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/be970e4eb5e6