Closed
Bug 1432728
Opened 6 years ago
Closed 6 years ago
Add a microbenchmark for HasRTLChars()
Categories
(Core :: Internationalization, enhancement, P3)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
We should make sure that the HasRTLChars() changes in queue are actual improvements.
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd3b069d070ffb5f5314b1f91ddca6090434fab7
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•6 years ago
|
||
With bug 1428774: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d611c4897eb8b6a1115ef71b087bd93c9027620
Blocks: 1428774
|
|
Assignee | |
Comment 4•6 years ago
|
||
With bug 1431025: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a597f0b9d49b0c665244a3caf3dbdc52ed33efeb
Blocks: 1431025
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8945027 -
Flags: review?(jfkthame)
Attachment #8945027 -
Flags: review?(gerv)
|
|
Assignee | |
Comment 5•6 years ago
|
||
gerv, requested review from you for the licensing of the test data. (CC-by-sa 3.0 Unported from Wikipedia. AFAICT, we already have CC-by-sa test data in the tree. Instead of baking the test data into gtest-flavored libxul, the test data is loaded from separate files at run-time.)
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8945027 [details] Bug 1432728 - Add a microbenchmark for HasRTLChars(). https://reviewboard.mozilla.org/r/215236/#review221206
Attachment #8945027 -
Flags: review?(jfkthame) → review+
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Comment 7•6 years ago
|
||
Separate files of test data under CC-BY-SA are fine; make sure they are clearly labelled, ideally by being in their own directory with a LICENSE file. Gerv
|
|
||
Comment 8•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8945027 [details] Bug 1432728 - Add a microbenchmark for HasRTLChars(). https://reviewboard.mozilla.org/r/215236/#review222346
Attachment #8945027 -
Flags: review?(gerv) → review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2cde1c294c0 Add a microbenchmark for HasRTLChars(). r=gerv,jfkthame
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a2cde1c294c0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•