1432746 - when Bookmark folder has sub folder, items in folder cannot be shown

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[ICHIMARU Takeshi(a.k.a. Ayakawa)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180123102017

Steps to reproduce:

1. open Library
2. make "test" folder in "Firefox Nightly Resources Folder
3. close library, and open library again


Actual results:

"Firefox Nightly Resources" folder only show "test" folder


Expected results:

folder must show other bookmark items

Comment 1

[ICHIMARU Takeshi(a.k.a. Ayakawa)]

Attachment: lib1.PNG

reproduce step 1

Comment 2

[ICHIMARU Takeshi(a.k.a. Ayakawa)]

Attachment: lib2.PNG

reproduce step 2

Comment 3

[ICHIMARU Takeshi(a.k.a. Ayakawa)]

Attachment: lib3.PNG

reproduce step 3

Comment 4

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
20180123102017

https://hg.mozilla.org/integration/autoland/json-pushes?changeset=cba9a29be139a663869a2c26557fd527a6981407&full=1

Comment 6

[Marco Bonardo [:mak]]

The bug is clear, I don't need further STR.

Comment 7

[Marco Bonardo [:mak]]

Attachment: Bug 1432746 - Some folders in the Library may not show their bookmark children.

Don't use the parent node options when creating new folder nodes, since they should retain
their original options.
Additionally, we can filter nodes in the queries rather than building a lot of nodes that
will be filtered out.

Review commit: https://reviewboard.mozilla.org/r/215392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215392/

Comment 8

[Marco Bonardo [:mak]]

there's a failure in the inherit test, but it passes for me locally. puzzling.

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 8945144 [details]
Bug 1432746 - Some folders in the Library may not show their bookmark children.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215392/diff/1-2/

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 8945144 [details]
Bug 1432746 - Some folders in the Library may not show their bookmark children.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215392/diff/2-3/

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8945144 [details]
Bug 1432746 - Some folders in the Library may not show their bookmark children.

https://reviewboard.mozilla.org/r/215392/#review221296

This seems to be working fine. r=Standard8

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405b7ae32467
Some folders in the Library may not show their bookmark children. r=standard8

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/405b7ae32467

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 60.0a1 (2018-01-26), so I'm marking this bug as VERIFIED. Thank you very much! \o/