1432749 - Parsing of window.open features is way too liberal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Anthony Ramine [:nox]]

Specification: https://html.spec.whatwg.org/multipage/window-object.html#concept-window-open-features-tokenize

When passed "scre enx=300", Gecko will just strip all whitespace and happily open a 300px wide window. This shouldn't happen.

Comment 1

[Anthony Ramine [:nox]]

Err, I meant "wid th=300" instead of "scre enx=300", for the window width. This does not change the fact that there is indeed a bug in the parsing code, though.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1432749 - Part 2: Introduce WindowFeature class with spec-compliant tokenization, and use it both in nsGlobalWindowOuter and nsWindowWatcher. r?smaug!

WindowFeature provides the tokenization and access to the map.

This change changes the following behavior:

• "*" value is removed, given it's unused.
  • Default width and default height handling is removed,
    given there's no callsites
• Some chrome-priv feature handling becomes stricter:
  • All substring match is removed and directly checks the item in the map

Depends on D67724

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1432749 - Part 1: Add DefaultHasher for nsTString. r?smaug!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a95f77732a1c
Part 1: Add DefaultHasher for nsTString. r=smaug
https://hg.mozilla.org/integration/autoland/rev/7e96d4acf317
Part 2: Introduce WindowFeature class with spec-compliant tokenization, and use it both in nsGlobalWindowOuter and nsWindowWatcher. r=smaug

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failures at open-features-tokenization-top-left.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/0dcaabc7bcf25fe8ffe84c8b88788676ed92a540
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297383519&repo=autoland&lineNumber=3083

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ad3abbfcb9
Part 1: Add DefaultHasher for nsTString. r=smaug
https://hg.mozilla.org/integration/autoland/rev/4a7e74f6a2e3
Part 2: Introduce WindowFeature class with spec-compliant tokenization, and use it both in nsGlobalWindowOuter and nsWindowWatcher. r=smaug

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/77ad3abbfcb9
https://hg.mozilla.org/mozilla-central/rev/4a7e74f6a2e3