1432756 - Clean up firefox-snap shell scripts

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Simon Fraser [:sfraser] ⌚️GMT]

Fix up runme.sh to pass linting

Comment 1

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1432756 Linting compliance for firefox-snap docker image

Review commit: https://reviewboard.mozilla.org/r/215260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215260/

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8945050 [details]
Bug 1432756 Linting compliance for firefox-snap docker image

https://reviewboard.mozilla.org/r/215260/#review220850

LGTM! Glad to see all these variables protected. There's one smal conflict you'll end up having because bug 1432417 reached central.

::: taskcluster/docker/firefox-snap/runme.sh:43
(Diff revision 1)
>  # Use release-specific list of locales to fetch L10N XPIs
>  $CURL -o "${WORKSPACE}/l10n_changesets.txt" "${CANDIDATES_DIR}/${VERSION}-candidates/build${BUILD_NUMBER}/l10n_changesets.txt"
>  cat "${WORKSPACE}/l10n_changesets.txt"
>  
>  mkdir -p "$DISTRIBUTION_DIR/extensions"
> -for locale in $(grep -v ja-JP-mac "${WORKSPACE}/l10n_changesets.txt" | awk '{print $1}'); do
> +while IFS= read -r locale

You shouldn't need that fix anymore thanks to bug 1432417. (You may need something else, though)

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

Good point, I'll swap to the new version and submit a new patch.

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

Comment on attachment 8945050 [details]
Bug 1432756 Linting compliance for firefox-snap docker image

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215260/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74678fd44d13
Linting compliance for firefox-snap docker image r=jlorenzo

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/74678fd44d13