Closed
Bug 1432765
Opened 6 years ago
Closed 6 years ago
Clean up docker recipe shell scripts
Categories
(Release Engineering :: General, enhancement)
Release Engineering
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: sfraser, Assigned: sfraser)
References
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sfraser
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8945056 [details] Bug 1432765 Linting compliance for docker recipes https://reviewboard.mozilla.org/r/215268/#review221028 Looks like dustin and wander have done most of the reviews for this file. Since this is a lint patch and mostly about formatting, I'm comfortable stamping it but we may want to at least let one of those two glance at it if you are looking for confidence. ::: taskcluster/docker/recipes/install-cmake.sh:18 (Diff revision 1) > "filename": "cmake-3.7.1.tar.gz", > "unpack": true > } > ] > EOF > -cd cmake-3.7.1 > +( neat, I didn't know you could use () to encapsulate pwd state
Attachment #8945056 -
Flags: review?(jlund) → review+
Pushed by sfraser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60a59819cf32 Linting compliance for docker recipes r=jlund
Comment 4•6 years ago
|
||
We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60a59819cf32
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•