Closed Bug 1432765 Opened 4 years ago Closed 4 years ago

Clean up docker recipe shell scripts

Categories

(Release Engineering :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
Tracking Status
firefox60 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → sfraser
Comment on attachment 8945056 [details]
Bug 1432765 Linting compliance for docker recipes

https://reviewboard.mozilla.org/r/215268/#review221028

Looks like dustin and wander have done most of the reviews for this file. Since this is a lint patch and mostly about formatting, I'm comfortable stamping it but we may want to at least let one of those two glance at it if you are looking for confidence.

::: taskcluster/docker/recipes/install-cmake.sh:18
(Diff revision 1)
>      "filename": "cmake-3.7.1.tar.gz",
>      "unpack": true
>    }
>  ]
>  EOF
> -cd cmake-3.7.1
> +(

neat, I didn't know you could use () to encapsulate pwd state
Attachment #8945056 - Flags: review?(jlund) → review+
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60a59819cf32
Linting compliance for docker recipes r=jlund
We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.
https://hg.mozilla.org/mozilla-central/rev/60a59819cf32
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.