1432771 - clear() helper shouldn't be logged in the output

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce:
1. Open the console
2. Evaluate `clear()`


Expected results:

The console output is cleared, i.e. the output is empty

Actual results:

The console gets cleared, but the "clear()" message is still visible.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This is intermittent, and probably caused by the batching we do.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1432771 - Clear queues in dispatchMessagesClear; .

In the console, to batch messages addition, we use queues which are
then comsumed once every 50ms. But if a message is push to a queue,
and dispatchMessagesClear is called before the 50ms interval, the message
would still be added to the output.
This is happening for example when calling the `clear` helper from jsterm.
Clearing the queues when calling dispatchMessagesClear fixes the issue.
A mochitest is added to make sure we don't regress this.

Review commit: https://reviewboard.mozilla.org/r/215314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215314/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8945089 [details]
Bug 1432771 - Clear queues in dispatchMessagesClear; .

https://reviewboard.mozilla.org/r/215314/#review221810

I'd like if we could audit the implementations of console.clear(), clear(), and the clear button/key shortcut in the UI and make sure we are sharing where appropriate. But in the meantime this looks like a nice simple fix!

::: commit-message-b0baa:4
(Diff revision 1)
> +Bug 1432771 - Clear queues in dispatchMessagesClear; r=bgrins.
> +
> +In the console, to batch messages addition, we use queues which are
> +then comsumed once every 50ms. But if a message is push to a queue,

Typo: 'consumed'

::: commit-message-b0baa:4
(Diff revision 1)
> +Bug 1432771 - Clear queues in dispatchMessagesClear; r=bgrins.
> +
> +In the console, to batch messages addition, we use queues which are
> +then comsumed once every 50ms. But if a message is push to a queue,

'push' -> 'pushed'

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8945089 [details]
Bug 1432771 - Clear queues in dispatchMessagesClear; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215314/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37cd2d413696
Clear queues in dispatchMessagesClear; r=bgrins.

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/37cd2d413696

Comment 7

[Tom Bannister]

I was able to reproduce this issue in Firefox 59.0.3 (20180427210249) on Windows 10x64.

I was not able to reproduce this issue on both Firefox 60.0b16 (20180426170554) on Windows 10x64 and on Firefox Nightly 61.0a1 (20180503220110) on Windows 10x64.

[bugday-20180502]