Bug 1432780 (split-devtools-actors)

[meta] DevTools actors cleanup: renaming and refactoring in smaller files

NEW
Unassigned

Status

enhancement
P3
normal
2 years ago
Last year

People

(Reporter: jdescottes, Unassigned)

Tracking

(Depends on 1 bug, Blocks 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 obsolete attachments)

Follow up to RFC 33 at https://github.com/devtools-html/rfcs/issues/33

The goal is to improve the readability of the files in devtools/server/actors. Ideally each actor should be in a separate file. Helper classes or functions should be extracted when it makes sense.

This should not be handled as a mass refactor. We should focus on the biggest and most problematic files and avoid splitting everything without consulting others.

Good candidates for splitting are:

- https://searchfox.org/mozilla-central/source/devtools/server/actors/inspector.js (at least extract DocumentWalker)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/object.js (defines 6 different actors)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/script.js (defines several actors and helper classes)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/styles.js (defines two actors)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/tab.js (extract DebuggerProgressListener)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/webconsole.js (defines two actors)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/webbrowser.js
Depends on: 1102240
Posted patch pso.patch (obsolete) — Splinter Review
will attach a try run when the tree is open is `mochitest-e10s-dt` a good suite?
Attachment #8947669 - Flags: review?(jdescottes)
Posted patch refactor-script.patch (obsolete) — Splinter Review
Refactor the script actor

     - Extract paused scoped objects.
     - Extract event loop stack. r=jdescottes
     - Extract actor stores. r=jdescottes
     - Move script.js to actor.js. r=jdescottes


https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f0688bdf9c6a9ad01f6d3e2454a86ef2eec920d
Attachment #8947669 - Attachment is obsolete: true
Attachment #8947669 - Flags: review?(jdescottes)
Attachment #8947711 - Flags: review?(jdescottes)
Depends on: 1435187
Thanks for working on the script actor Jason! Since this is a meta bug, I'm moving everything to a dedicated bug. Bug 1435187
Attachment #8947711 - Attachment is obsolete: true
Attachment #8947711 - Flags: review?(jdescottes)
Depends on: 1438370
Alias: split-devtools-actors
Depends on: 1439000
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.