1432780 - (split-devtools-actors) [meta] DevTools actors cleanup

Status: NEW

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to RFC 33 at https://github.com/devtools-html/rfcs/issues/33

The goal is to improve the readability of the files in devtools/server/actors. Ideally each actor should be in a separate file. Helper classes or functions should be extracted when it makes sense.

This should not be handled as a mass refactor. We should focus on the biggest and most problematic files and avoid splitting everything without consulting others.

Good candidates for splitting are:

- https://searchfox.org/mozilla-central/source/devtools/server/actors/inspector.js (at least extract DocumentWalker)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/object.js (defines 6 different actors)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/script.js (defines several actors and helper classes)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/styles.js (defines two actors)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/tab.js (extract DebuggerProgressListener)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/webconsole.js (defines two actors)
- https://searchfox.org/mozilla-central/source/devtools/server/actors/webbrowser.js

Comment 1

[Jason Laster [:jlast]]

Attachment: pso.patch

will attach a try run when the tree is open is `mochitest-e10s-dt` a good suite?

Comment 2

[Jason Laster [:jlast]]

Attachment: refactor-script.patch

Refactor the script actor

     - Extract paused scoped objects.
     - Extract event loop stack. r=jdescottes
     - Extract actor stores. r=jdescottes
     - Move script.js to actor.js. r=jdescottes


https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f0688bdf9c6a9ad01f6d3e2454a86ef2eec920d

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for working on the script actor Jason! Since this is a meta bug, I'm moving everything to a dedicated bug. Bug 1435187