Closed Bug 1432834 Opened 6 years ago Closed 6 years ago

Canvas rendering is broken

Categories

(DevTools :: Netmonitor, defect, P1)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox-esr52 unaffected, firefox60 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox60 --- verified

People

(Reporter: Honza, Assigned: ochameau)

References

Details

(Keywords: regression)

Attachments

(3 files)

canvas-broken.png
57.48 KB, image/png
Details
Bug 1432834 - fix vertical alignment of netmonitor requests
59 bytes, text/x-review-board-request
Details
Bug 1432834 - Fix request list line height.
59 bytes, text/x-review-board-request
Honza
: review+
Details
Attached image canvas-broken.png — 
Vertical lines rendered in Net panel's content indicating onLoad and DOMContentLoad events as well as other gray lines are broken.

See the attached screenshot.

Honza
Tim: can you please find regression range (it must be fairly new)

Honza
Flags: needinfo?(ntim.bugs)
Priority: -- → P1
Adding the regressionwindow-wanted flag in case someone can look at it before I do (I don't have time this week).
Keywords: regression, regressionwindow-wanted
Regression from Bug 1431132 (so FF60 only)
Blocks: 1431132
Keywords: regressionwindow-wanted
Thanks Julian!
Flags: needinfo?(ntim.bugs)
Removing display: table-row broke the vertical alignement and height of the row content. The patch attached here fixes it by forcing the height on the child nodes of .request-list-item, + a few other changes. If anyone wants to give a shot at a cleaner fix, feel free to do so.
I'll look into this.
Assignee: nobody → poirot.alex
Comment on attachment 8945353 [details]
Bug 1432834 - Fix request list line height.

https://reviewboard.mozilla.org/r/215554/#review221184

Thank for quick patch!

R+, fixes the problem for me.

Honza
Attachment #8945353 - Flags: review?(odvarko) → review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4675ca07f73
Fix request list line height. r=Honza
https://hg.mozilla.org/mozilla-central/rev/e4675ca07f73
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Flags: qe-verify+
Verified fixed using the latest Nightly 60.0a1 (2018-03-12) on Mac OS X 10.12, Ubuntu 16.04 x64 and Windows 10 x64.
Status: RESOLVED → VERIFIED
status-firefox60: fixed → verified
Flags: qe-verify+
Product: Firefox → DevTools
status-firefox58: unaffected → ---
status-firefox59: unaffected → ---
Flags: in-qa-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: