1432896 - Pinning jobs from the Failure Summary pane is sluggish

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

STR:
1) Load https://treeherder.mozilla.org/#/jobs?repo=try&noautoclassify&revision=44ed151b0d274b899b4016045a1f8970324591cf
2) Select the failed build job and wait for suggestions to come up.
3) Click the pin icon for the bug 1432009 suggestion.

Expected results:
No noticeable lag between clicking the pin icon and the bug number showing up in the appropriate box on the pinboard.

Actual results:
There's a noticeable delay. Interestingly, pinning the job from the "Failure Classification" pane is more or less instantaneous still, so it appears to be limited only to the "Failure Summary" pane.

This regressed within the last few weeks and reproduces for me on Fx57 with a clean profile as well. It is actually harmful to workflow because it slows down being able to submit classification data after making the classification.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bisecting reveals this started after bug 1419612 landed.

If one is not logged in (as a sheriff), the 'Failure Classification' panel shows the same content like 'Failure Summary', but the selected suggestion gets added faster to the pinboard.

Comment 2

[Cameron Dawson [:camd]]

I have a PR that I will be submitting today and then I will tackle this bug next.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3224

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8950729 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3224

Just a matter of the AngularJS watch cycle not getting invoked when we call something from ReactJS.  I intend to convert the rest of the details (bottom) panel to React in my next iteration, so it'll fix all this anyway.

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8950729 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3224

Good spot - thank you for fixing this! :-)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dedd1b59904a01d30489ad06c153dc2ed48f464f
Bug 1432896 - Fix sluggish pinning of job bugs