Open Bug 1432914 Opened 6 years ago Updated 2 years ago

manifestparser glues together skip-if from manifest header and test sections, sometimes producing unparseable results

Categories

(Testing :: Mozbase, enhancement, P3)

Product:
Testing
Component:
Mozbase
Version:
59 Branch
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: kats, Unassigned)

Details

I added a "skip-if = webrender" condition to a test in dom/events/test/pointerevents/mochitest.ini [1]. However, when the expression parser gets around to parsing the expression, it ends up with the expression:
  (os == 'android') || (webrender #)
which it can't parse, and falls over [2]. Based on the logging I added in that try push it appears that this is happening because the manifest parser takes the skip-if condition in the [DEFAULT] section of the file (which is the os == 'android' clause) and then tries to glue it to the test-specific condition, which includes a trailing '#' from the comment (dunno why that's there). After doing the gluing it ends up with the above malformed expression which it can't parse, even though it can parse those expressions individually just fine.

[1] https://hg.mozilla.org/try/rev/2a59f014066fc50837074706af442073ed18ecca#l2.12
[2] See the mochitest-1 job in https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b38e33c10e0088228251da5c9e614e3a0bb2834
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.