Closed Bug 1432941 Opened 3 years ago Closed 1 year ago

Intermittent TEST-UNEXPECTED-PASS | w3c-css/received/css-multicol/multicol-inherit-003.xht == w3c-css/received/css-multicol/multicol-inherit-3-ref.xht | image comparison, max difference: 0, number of differing pixels: 0

Categories

(Core :: Layout, defect, P5)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: ccoroiu)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file, 1 obsolete file)

Disable multicol-inherit-003.xht on mac for frequent failures
1.34 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
It's my first reftest disable, so I am not sure if I did good with this patch
Assignee: nobody → ccoroiu
Attachment #9018813 - Flags: review?(jmaher)
Comment on attachment 9018813 [details] [diff] [review]
Disable multicol-inherit-003.xht on mac for frequent failures

Review of attachment 9018813 [details] [diff] [review]:
-----------------------------------------------------------------

for your first attempt at a reftest manifest, this is a really good start

::: layout/reftests/w3c-css/received/reftest.list
@@ +101,4 @@
>  fails == css-multicol/multicol-height-block-child-001.xht css-multicol/multicol-height-block-child-001-ref.xht
>  fuzzy(0-255,0-3762) == css-multicol/multicol-inherit-001.xht css-multicol/multicol-inherit-001-ref.xht
>  fuzzy(0-135,0-1893) fails-if(webrender&&cocoaWidget) == css-multicol/multicol-inherit-002.xht css-multicol/multicol-inherit-002-ref.xht
> +skip-if(cocoaWidget) == css-multicol/multicol-inherit-003.xht css-multicol/multicol-inherit-3-ref.xht # Bug 1432941

in this case we always expect this to fail, but it is passing on osx sometimes, so to stop this we need to keep it failing everywhere else, but skipped for osx.

skip-if(cocoaWidget) fails-if(!cocoaWidget) ...
Attachment #9018813 - Flags: review?(jmaher) → review-
Attachment #9018813 - Attachment is obsolete: true
Attachment #9018817 - Flags: review?(jmaher)
Attachment #9018817 - Flags: review?(jmaher) → review+
Keywords: checkin-needed, leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

For the record, multicol-inherit-003.xht failed because Ahem font was not loaded properly per bug 1594937 comment 2. However, I removed the entire w3c-css/received reftests, so this is no longer an issue.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.