Closed
Bug 1432941
Opened 7 years ago
Closed 5 years ago
Intermittent TEST-UNEXPECTED-PASS | w3c-css/received/css-multicol/multicol-inherit-003.xht == w3c-css/received/css-multicol/multicol-inherit-3-ref.xht | image comparison, max difference: 0, number of differing pixels: 0
Categories
(Core :: Layout, defect, P5)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: intermittent-bug-filer, Assigned: ccoroiu)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])
Attachments
(1 file, 1 obsolete file)
1.34 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Filed by: philringnalda [at] gmail.com
https://treeherder.mozilla.org/logviewer.html#?job_id=158221341&repo=mozilla-inbound
https://queue.taskcluster.net/v1/task/UCMRUM6SSxuhE8Pgywb5-w/runs/0/artifacts/public/logs/live_backing.log
https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/UCMRUM6SSxuhE8Pgywb5-w/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 36•7 years ago
|
||
It's my first reftest disable, so I am not sure if I did good with this patch
Assignee: nobody → ccoroiu
Attachment #9018813 -
Flags: review?(jmaher)
Comment 37•7 years ago
|
||
Comment on attachment 9018813 [details] [diff] [review]
Disable multicol-inherit-003.xht on mac for frequent failures
Review of attachment 9018813 [details] [diff] [review]:
-----------------------------------------------------------------
for your first attempt at a reftest manifest, this is a really good start
::: layout/reftests/w3c-css/received/reftest.list
@@ +101,4 @@
> fails == css-multicol/multicol-height-block-child-001.xht css-multicol/multicol-height-block-child-001-ref.xht
> fuzzy(0-255,0-3762) == css-multicol/multicol-inherit-001.xht css-multicol/multicol-inherit-001-ref.xht
> fuzzy(0-135,0-1893) fails-if(webrender&&cocoaWidget) == css-multicol/multicol-inherit-002.xht css-multicol/multicol-inherit-002-ref.xht
> +skip-if(cocoaWidget) == css-multicol/multicol-inherit-003.xht css-multicol/multicol-inherit-3-ref.xht # Bug 1432941
in this case we always expect this to fail, but it is passing on osx sometimes, so to stop this we need to keep it failing everywhere else, but skipped for osx.
skip-if(cocoaWidget) fails-if(!cocoaWidget) ...
Attachment #9018813 -
Flags: review?(jmaher) → review-
Assignee | ||
Comment 38•7 years ago
|
||
Attachment #9018813 -
Attachment is obsolete: true
Attachment #9018817 -
Flags: review?(jmaher)
Updated•7 years ago
|
Attachment #9018817 -
Flags: review?(jmaher) → review+
Updated•7 years ago
|
Keywords: checkin-needed,
leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Comment 39•7 years ago
|
||
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment 41•7 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 57•6 years ago
|
||
uplift |
Comment hidden (Intermittent Failures Robot) |
Comment 59•5 years ago
|
||
For the record, multicol-inherit-003.xht
failed because Ahem font was not loaded properly per bug 1594937 comment 2. However, I removed the entire w3c-css/received reftests, so this is no longer an issue.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•