1432977 - Remove all members from nsIDOMHTMLElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove nsIDOMHTMLElement's draggable attribute

MozReview-Commit-ID: Gj8thsaNGCF

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove nsIDOMHTMLElement's spellcheck attribute

MozReview-Commit-ID: B07hMx3LAed

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove nsIDOMHTMLElement's offsetWidt/Height attributes

MozReview-Commit-ID: EoSwBkeGj60

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8945307 [details] [diff] [review]
part 3.  Remove nsIDOMHTMLElement's offsetWidt/Height attributes

Review of attachment 8945307 [details] [diff] [review]:
-----------------------------------------------------------------

nit: "offsetWidt" in the patch summary.

::: dom/interfaces/html/nsIDOMHTMLElement.idl
@@ +7,3 @@
>  
>  /**
>   * The nsIDOMHTMLElement interface is the primary [X]HTML element

Is this comment still useful?

::: editor/libeditor/HTMLInlineTableEditor.cpp
@@ +202,5 @@
>  {
>    if (!mInlineEditedCell) {
>     return NS_OK;
>    }
> +  

nit: trailing whitespace.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> nit: "offsetWidt" in the patch summary.

Fixed.

> Is this comment still useful?

This while file dies in bug 1418085 so I'm not going to worry about it.  ;)

> nit: trailing whitespace.

Fixed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0759dfa715e
part 1.  Remove nsIDOMHTMLElement's draggable attribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/b99a55d47c97
part 2.  Remove nsIDOMHTMLElement's spellcheck attribute. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1deaf1c9d50
part 3.  Remove nsIDOMHTMLElement's offsetWidth/Height attributes.  r=mccr8

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e0759dfa715e
https://hg.mozilla.org/mozilla-central/rev/b99a55d47c97
https://hg.mozilla.org/mozilla-central/rev/c1deaf1c9d50