1433024 - test_refresh_firefox.py is going to permafail when Gecko 60 merges to Beta on 2018-03-01

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing tests on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=158360654&repo=try

Verified via bisection on Try that bug 862127 is the culprit. Doesn't reproduce on debug or DevEdition builds, for whatever that tells you. The patches below should suffice for reproducing:
https://hg.mozilla.org/try/rev/1551fd04a54451d0db1df7ae2f5a59640f3fe4fd
https://hg.mozilla.org/try/rev/6283b117d5b3aabede69a65cf3c9e2345ba2720f

Comment 1

[:Gijs (he/him)]

Looks like we tell the browser to restart and profile reset, and then things get stuck:

[task 2018-01-25T02:12:05.452Z] 02:12:05     INFO -  1516846325449	Marionette	TRACE	4 -> [0,30,"executeScript",{"scriptTimeout":null,"newSandbox":true,"args":[],"filename":"marionette.py","script":"\n               ... application-requested\", null);\n                return cancelQuit.data;\n                ","sandbox":"default","line":1052}]
[task 2018-01-25T02:12:05.468Z] 02:12:05     INFO -  1516846325458	Marionette	TRACE	4 <- [1,30,null,{"value":false}]
[task 2018-01-25T02:12:05.468Z] 02:12:05     INFO -  1516846325460	Marionette	TRACE	4 -> [0,31,"setContext",{"value":"chrome"}]
[task 2018-01-25T02:12:05.468Z] 02:12:05     INFO -  1516846325460	Marionette	TRACE	4 <- [1,31,null,{}]
[task 2018-01-25T02:12:05.469Z] 02:12:05     INFO -  1516846325461	Marionette	TRACE	4 -> [0,32,"quitApplication",{"flags":["eRestart","eAttemptQuit"]}]
[task 2018-01-25T02:12:05.469Z] 02:12:05     INFO -  1516846325462	Marionette	DEBUG	New connections will no longer be accepted
[task 2018-01-25T02:12:05.587Z] 02:12:05     INFO -  1516846325578	Marionette	TRACE	4 <- [1,32,null,{"cause":"restart"}]
[task 2018-01-25T02:12:05.587Z] 02:12:05     INFO -  1516846325585	Marionette	DEBUG	Closed connection 4
[task 2018-01-25T02:12:05.789Z] 02:12:05     INFO -  *** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping
[task 2018-01-25T02:12:05.891Z] 02:12:05     INFO -  1516846325884	Marionette	DEBUG	Received observer notification xpcom-shutdown
[task 2018-01-25T02:13:06.250Z] 02:13:06     INFO -  GLib-GIO-Message: Using the 'memory' GSettings backend.  Your settings will not be saved or shared with other applications.

and then marionette gives up after that 1 minute.


If this only happens on opt beta, I wonder if it's another expired telemetry probe or something, or a gated pref?

Comment 2

[Alex Thayer [:alexical] (she/her)]

Ah, think I found it. The difference between DevEdition and Beta for this is the brand.properties file. DevEdition is missing a set of properties which means we never make it to this line[1]. Looks like I somehow missed converting the default implementation of getSourceHomePageURL[2] in MigrationUtils.jsm. I'll get a patch up for this shortly.


[1]: https://searchfox.org/mozilla-central/rev/062e1cf551f5bf3f0af33671b818f75a55ac497b/browser/components/migration/content/migration.js#330
[2]: https://searchfox.org/mozilla-central/rev/062e1cf551f5bf3f0af33671b818f75a55ac497b/browser/components/migration/MigrationUtils.jsm#191

Comment 3

[Alex Thayer [:alexical] (she/her)]

I'm not familiar with how to trigger a try run which will reproduce this in order to verify the fix. Is there something I'm not seeing?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Add the two patches from #c0 to your queue.

Comment 5

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1433024 - Update MigrationUtils' sourceHomePageURL

Fairly trivial. This was breaking for the test_refresh_firefox
test in beta, since the code which calls this is only active if
certain branding strings are present.

Review commit: https://reviewboard.mozilla.org/r/216266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216266/

Comment 6

[:Gijs (he/him)]

Comment on attachment 8946300 [details]
Bug 1433024 - Update MigrationUtils' sourceHomePageURL

https://reviewboard.mozilla.org/r/216266/#review222194

Not sure whether to laugh or cry. r=me

Can we peste... I mean, politely ask, UX to make a decision about whether we can rip the homepage stuff out? And/or fix the branding thing and/or our handling of the strings being missing so that this won't have differing behaviour on different branches? (in a different bug)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8946300 [details]
Bug 1433024 - Update MigrationUtils' sourceHomePageURL

Looks great on Try too!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f3d4c2924d2
Update MigrationUtils' sourceHomePageURL r=Gijs

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/6f3d4c2924d2