1433036 - ./mach bootstrap doesn't install npm on FreeBSD

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

npm is packaged separately on FreeBSD. See https://www.freshports.org/www/npm then click to expand pseudo pkg-plist.

$ ./mach bootstrap
$ ./mach eslint
Node Package Manager (npm) is either not installed or installed to a
non-standard path. Please install npm from https://nodejs.org (it comes as an
option in the node installation) and try again.

Valid installation paths:
A failure occured in the eslint linter.
? 1 problem (0 errors, 0 warnings, 1 failure)

Comment 1

[Jan Beich]

Attachment: Bug 1433036 - FreeBSD bootstrap: add npm for linting after bug 1433036.

Downstream npm package already depends node package, no need to
specify it explicitly. Also, node package refers to the latest NodeJS
but npm package can be built against an older version.

Review commit: https://reviewboard.mozilla.org/r/215548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215548/

Comment 2

[Jan Beich]

Attachment: Bug 1433036 - OpenBSD bootstrap: node-devel package doesn't exist.

lang/node aka node package is what actually installs node and npm executables.
https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/lang/node/pkg/PLIST?rev=HEAD

Review commit: https://reviewboard.mozilla.org/r/215550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215550/

Comment 3

[Landry Breuil (:gaston)]

Comment on attachment 8945350 [details]
Bug 1433036 - OpenBSD bootstrap: node-devel package doesn't exist.

https://reviewboard.mozilla.org/r/215550/#review221172

Sigh. Let's pull the kitchensink..

Comment 4

[Mark Banner (:standard8)]

FYI, I went with what was listed on https://nodejs.org/en/download/package-manager/#freebsd-and-openbsd, so you might want to get that updated as well, though it looks like I made a mistake on the OpenBSD side of things.

Comment 5

[Jan Beich]

(In reply to Mark Banner (:standard8) from comment #4)
> FYI, I went with what was listed on
> https://nodejs.org/en/download/package-manager/#freebsd-and-openbsd, so you
> might want to get that updated as well, though it looks like I made a
> mistake on the OpenBSD side of things.

FreeBSD removed www/node-devel more than 1 year ago.
https://svnweb.freebsd.org/changeset/ports/413225

As for upstream not mentioning npm is packaged separately maybe downstream maintainer knows. I don't use NodeJS myself nor have time to get involved for a one-off trivia.

Comment 6

[Landry Breuil (:gaston)]

I had faith and tried mach eslint on openbsd, as expected it installed all the nodejs ecosystem, and then failed anyway...

eslint-plugin-react v7.1.0 needs to be installed locally.
eslint-plugin-no-unsanitized v2.0.1 needs to be installed locally.
eslint-plugin-html v2.0.3 needs to be installed locally.
eslint-plugin-spidermonkey-js vfile:tools/lint/eslint/eslint-plugin-spidermonkey-js needs to be installed locally.
sax v1.2.4 needs to be installed locally.
eslint v3.19.0 needs to be installed locally.
eslint-plugin-mozilla vfile:tools/lint/eslint/eslint-plugin-mozilla needs to be installed locally.
ini-parser v0.0.2 needs to be installed locally.
Installing eslint for mach using "/usr/local/bin/npm install --loglevel=error"...

ESLint and approved plugins installed successfully!

NOTE: Your local eslint binary is at /home/landry/src/m-c/node_modules/.bin/eslint

Error running mach:

    ['eslint']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

error: must call (at least) setupterm() first

  File "/home/landry/src/m-c/tools/lint/mach_commands.py", line 63, in eslint
    argv=extra_args, **kwargs)
  File "/home/landry/src/m-c/python/mach/mach/registrar.py", line 129, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/home/landry/src/m-c/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
  File "/home/landry/src/m-c/tools/lint/mach_commands.py", line 44, in lint
    return cli.run(*runargs, **lintargs)
  File "/home/landry/src/m-c/python/mozlint/mozlint/cli.py", line 163, in run
    formatter = formatters.get(fmt)
  File "/home/landry/src/m-c/python/mozlint/mozlint/formatters/__init__.py", line 29, in get
    return all_formatters[name](**fmtargs)
  File "/home/landry/src/m-c/python/mozlint/mozlint/formatters/stylish.py", line 53, in __init__
    self.num_colors = self.term.number_of_colors
  File "/home/landry/src/m-c/third_party/python/blessings/blessings/__init__.py", line 257, in number_of_colors
    colors = tigetnum('colors')  # Returns -1 if no color support, -2 if no such cap.

why am i not surprised ?

Comment 7

[Landry Breuil (:gaston)]

Reminds me of https://bugzilla.mozilla.org/show_bug.cgi?id=878089 ...

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8945349 [details]
Bug 1433036 - FreeBSD bootstrap: add npm for linting after bug 1433036.

https://reviewboard.mozilla.org/r/215548/#review221264

Comment 9

[Nathan Froyd [:froydnj]]

Comment on attachment 8945350 [details]
Bug 1433036 - OpenBSD bootstrap: node-devel package doesn't exist.

https://reviewboard.mozilla.org/r/215550/#review221266

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/687c51a21e42
FreeBSD bootstrap: add npm for linting after bug 1433036. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/cac44122e005
OpenBSD bootstrap: node-devel package doesn't exist. r=froydnj,gaston

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/687c51a21e42
https://hg.mozilla.org/mozilla-central/rev/cac44122e005

Comment 12

[Jan Beich]

Comment on attachment 8945350 [details]
Bug 1433036 - OpenBSD bootstrap: node-devel package doesn't exist.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1424921 regression
[User impact if declined]: Broken ./mach bootstrap on OpenBSD
[Is this code covered by automated tests?]: No, it's for Tier3 platform
[Has the fix been verified in Nightly?]: No but has r+ from OpenBSD user
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Can only break build
[String changes made/needed]: None

Comment 13

[Jan Beich]

Comment on attachment 8945349 [details]
Bug 1433036 - FreeBSD bootstrap: add npm for linting after bug 1433036.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1424921 followup
[User impact if declined]: ./mach bootstrap doesn't install a dependency for *lint
[Is this code covered by automated tests?]: No, it's for Tier3 platform
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Can only break build
[String changes made/needed]: None

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8945350 [details]
Bug 1433036 - OpenBSD bootstrap: node-devel package doesn't exist.

Risk is low, as Jan points out if it's wrong the build won't work and that will be obvious. Let's get this into 59 beta 6.

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a88fde4219d9
https://hg.mozilla.org/releases/mozilla-beta/rev/e25fc7c4ef8c