Implement RsdparsaSdpMediaSection::SetPort(unsigned int port) Rust SDP Parser bindings

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: dminor, Assigned: johannes.willbold)

Tracking

(Blocks 1 bug)

58 Branch
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

a year ago
Summary: Implement RustSdpMediaSection::SetPort(unsigned int port) Rust SDP Parser bindings → Implement RsdparsaSdpMediaSection::SetPort(unsigned int port) Rust SDP Parser bindings

Updated

11 months ago
Assignee: nobody → johannes.willbold
Comment hidden (mozreview-request)
(Reporter)

Comment 2

11 months ago
mozreview-review
Comment on attachment 8983239 [details]
Bug 1433093: Implemented RsdparsaSdpMediaSection::SetPort.

https://reviewboard.mozilla.org/r/249120/#review255466

::: media/webrtc/signaling/gtest/sdp_unittests.cpp:3925
(Diff revision 1)
> +           "a=sendonly" CRLF,
> +           false);
> +
> +   ASSERT_TRUE(!!mSdp) << "Parse failed: " << GetParseErrors();
> +
> +   auto currentPort = mSdp->GetMediaSection(0).GetPort();

Might as well check the value of currentPort here.

::: media/webrtc/signaling/src/sdp/RsdparsaSdpMediaSection.cpp:62
(Diff revision 1)
>  }
>  
>  void
>  RsdparsaSdpMediaSection::SetPort(unsigned int port)
>  {
> -  // TODO, see Bug 1433093
> +  sdp_set_media_port(mSection,port);

nit: please add a space after the comma
Attachment #8983239 - Flags: review?(dminor) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

11 months ago
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/91ef628a1f06
Implemented RsdparsaSdpMediaSection::SetPort. r=dminor

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/91ef628a1f06
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.