1433117 - Update Debugger Frontend v11

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd2755fa084953eae9a55140997ff7952115e5cc

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44c138d7cd245fee8543780d0be904b9bdfd9605

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=308086b77d4987d8fecdd0ed324c0c998f8cb162

Comment 4

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee065933babc8c3cc22de77e0ba483487ab1f351

^ without the reverted commits

Comment 5

[Jason Laster [:jlast]]

So... the current release has some issues w/ dbg-sources on mac debug...


here is a try run of moz/central - i will re-run a bunch here as a control
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bb6fd0e6040c36be7ccb516b3cc05244d168b38

Comment 6

[Jason Laster [:jlast]]

Here is 11-1 which is about the half way point between 10 and 11.

https://github.com/devtools-html/debugger.html/tree/release-11-1


https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd4f2850fc17dc7f1e981498cf271560d80eefab

Comment 7

[Jason Laster [:jlast]]

also worth sharing this screenshot from a failed run:
https://public-artifacts.taskcluster.net/HONdZaKCSAueRnOIuPDouA/0/public/test_info/mozilla-test-fail-screenshot_0I5tc8.png

i'm wondering if this is related to the js byte code cache issue...

Comment 8

[Jason Laster [:jlast]]

a new 11-1 try run

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72fa52f4d6691ae7ecbffb2f7188cc953d4d3e3c

Comment 9

[Jason Laster [:jlast]]

a new try run sans the rtl changes

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0409c29296add0090d62c6abc78f786b4cfecfd

Comment 10

[Jason Laster [:jlast]]

Attachment: release-11.patch

Comment 11

[Jason Laster [:jlast]]

A new try run w/ v11 and a fresh central:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e0ef523951173d02e2da861ad64dbfa7800ee18
https://github.com/devtools-html/debugger.html/compare/release-10...release-11

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb00e1657e6
Update Debugger Frontend v11. r=jdescottes

Comment 13

[Julian Descottes [:jdescottes]]

Comment on attachment 8946351 [details] [diff] [review]
release-11.patch

Review of attachment 8946351 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: devtools/client/debugger/new/README.mozilla
@@ +2,5 @@
>  See https://github.com/devtools-html/debugger.html
>  
> +Version v11.0
> +Comparison: https://github.com/devtools-html/debugger.html/compare/release-10...release-11
> +Commit: https://github.com/devtools-html/debugger.html/commit/4ef9b879ef7b51430e4acdadfd24a8d7e9f64c82

I trust that this will no longer 404 after you push?

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9bb00e1657e6

Comment 15

[Alexandre Poirot [:ochameau]]

This update regressed:
* complicated.jsdebugger.open by 12%
* complicated.jsdebugger.reload by 9%
* custom.jsdebugger.open by 5%
http://firefox-dev.tools/performance-dashboard/tools/debugger.html?days=14&filterstddev=true

Comment 16

[Alexandre Poirot [:ochameau]]

This translates into the debugger being significantly slower to open and reload against bild.de copy that DAMP is using.
And only slower to open against the sourcemapped example:
https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/devtools/addon/content/pages/custom/debugger
(a fork of https://github.com/facebookincubator/create-react-app)

Comment 17

[Jason Laster [:jlast]]

Thanks for sharing - here's a quick sheet of the commits added and my guesses on perf

https://docs.google.com/spreadsheets/d/1YYlbBKx4ZrtLjEVUciFjRSgO7WLYH8NEsEQ4MrQfqHQ/edit#gid=0

The sheet was created w/ this git script: `git log --pretty=format:"%h,%an,%s" v10.0...v11.0`