Closed Bug 1433117 Opened 2 years ago Closed 2 years ago

Update Debugger Frontend v11

Categories

(DevTools :: Debugger, defect)

defect
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jlaster
So... the current release has some issues w/ dbg-sources on mac debug...


here is a try run of moz/central - i will re-run a bunch here as a control
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bb6fd0e6040c36be7ccb516b3cc05244d168b38
also worth sharing this screenshot from a failed run:
https://public-artifacts.taskcluster.net/HONdZaKCSAueRnOIuPDouA/0/public/test_info/mozilla-test-fail-screenshot_0I5tc8.png

i'm wondering if this is related to the js byte code cache issue...
Attached patch release-11.patchSplinter Review
Attachment #8946351 - Flags: review?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb00e1657e6
Update Debugger Frontend v11. r=jdescottes
Comment on attachment 8946351 [details] [diff] [review]
release-11.patch

Review of attachment 8946351 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: devtools/client/debugger/new/README.mozilla
@@ +2,5 @@
>  See https://github.com/devtools-html/debugger.html
>  
> +Version v11.0
> +Comparison: https://github.com/devtools-html/debugger.html/compare/release-10...release-11
> +Commit: https://github.com/devtools-html/debugger.html/commit/4ef9b879ef7b51430e4acdadfd24a8d7e9f64c82

I trust that this will no longer 404 after you push?
Attachment #8946351 - Flags: review?(jdescottes) → review+
https://hg.mozilla.org/mozilla-central/rev/9bb00e1657e6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
This update regressed:
* complicated.jsdebugger.open by 12%
* complicated.jsdebugger.reload by 9%
* custom.jsdebugger.open by 5%
http://firefox-dev.tools/performance-dashboard/tools/debugger.html?days=14&filterstddev=true
Flags: needinfo?(jlaster)
This translates into the debugger being significantly slower to open and reload against bild.de copy that DAMP is using.
And only slower to open against the sourcemapped example:
https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/devtools/addon/content/pages/custom/debugger
(a fork of https://github.com/facebookincubator/create-react-app)
Thanks for sharing - here's a quick sheet of the commits added and my guesses on perf

https://docs.google.com/spreadsheets/d/1YYlbBKx4ZrtLjEVUciFjRSgO7WLYH8NEsEQ4MrQfqHQ/edit#gid=0

The sheet was created w/ this git script: `git log --pretty=format:"%h,%an,%s" v10.0...v11.0`
Flags: needinfo?(jlaster)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.