1433123 - Console launchpad does not work

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce:
1. cd devtools/client/webconsole
2. yarn install
3. yarn start


Expected results:

I can access the console in a tab

Actual results:

There is an error message (about postCSS, and spread operator issues)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1433123 - Fix console launchpad; .

Updating to latest devtools-launchpad add adding the
disablePostCSS option fixes the postCSS errors.
Remove the netmonitor from babelExclude and add the
rewrite-lazy-getter loader fixes the issues about the use
of the object spread operator.

Review commit: https://reviewboard.mozilla.org/r/215640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215640/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8945479 [details]
Bug 1433123 - Fix console launchpad; .

https://reviewboard.mozilla.org/r/215640/#review221282

Thanks, fixes the issue for me!

R+, and inline question

Thanks Nicolas,
Honza

::: devtools/client/webconsole/.babelrc:4
(Diff revision 1)
>  {
>    "env": {
>      "test": {
>        "presets": ["es2015", "es2017"]

Why do we need these presets?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8945479 [details]
Bug 1433123 - Fix console launchpad; .

https://reviewboard.mozilla.org/r/215640/#review221286

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/586c8597bb34
Fix console launchpad; r=Honza.

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/586c8597bb34