Closed Bug 1433133 Opened 2 years ago Closed 2 years ago

Make Activity Stream the only built in page for Home and New Tab

Categories

(Firefox :: New Tab Page, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Iteration:
60.4 - Mar 12
Tracking Status
firefox60 --- fixed

People

(Reporter: Mardak, Assigned: Gijs)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

Currently, about:home can revert to the classic version by turning off browser.newtabpage.activity-stream.aboutHome.enabled and about:newtab can revert to Tiles by turning off browser.newtabpage.activity-stream.enabled.

Both sets of code, etc. have to be kept around right now.

Anything that needs to be done before this can be cleaned up?
We did update the old pages to run shield A/B test shield studies on Release to determine if having activity stream or the previous version was better.
Depends on: 1400326, 1411419
Bug 1409054 will be for removing the other about:home built in page.
Iteration: --- → 60.4 - Mar 12
Depends on: 1409054
Priority: -- → P2
Summary: Make Activity Stream the only default for Home and New Tab → Make Activity Stream the only built in page for Home and New Tab
Whiteboard: [AS60MVP]
The existing preferences UIs will exist and more. In particular with bug 1417155, a user will be able to individually configure the home page and new tab page to be the default, blank, custom url or extension. This is on top of the existing new tab customization that allow for turning off each / every section as well as various sub options for sections.
See Also: → 1417155
Depends on: 1433324
Disabling browser.newtabpage.activity-stream.enabled is required in order to pin a local html file to the newtab page.
The new page does not have direct privileges to load file: links although it could send a message to get it loaded. That's bug 1401932.
Depends on: 1401932
Depends on: 1370930
Iteration: 60.4 - Mar 12 → ---
Priority: P2 → P3
Blocks: 1437659
Iteration: --- → 61.1 - Mar 26
Whiteboard: [AS60MVP] → [AS61MVP]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Last trypush with the previous version of these patches, which hadn't yet removed the .dtd and .properties files, and cleaned up the spare whitelist item in all_files_referenced.js, but otherwise seem to be green (at least at time of writing):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=291768f93918d729041352d459f2dfd492e1d4b9&selectedJob=166308309
If the newtab directory is completely removed now, could you also remove:

https://searchfox.org/mozilla-central/rev/efce4ceddfbe5fe4e2d74f1aed93894bada9b273/.eslintignore#74

whilst you're at it?

Thanks!
Depends on: 1443646
These should all be unused: browser.newtabpage.enhanced, browser.newtabpage.compact, browser.newtabpage.thumbnailPlaceholder
(In reply to Dão Gottwald [::dao] from comment #12)
> These should all be unused: browser.newtabpage.enhanced,
> browser.newtabpage.compact, browser.newtabpage.thumbnailPlaceholder

Yes, I was just looking at that - unfortunately it's not that simple, because of the NewTabUtils in toolkit, which AS implicitly still calls into, and which rely on the 'enhanced' pref, at least. I'll look at cleaning out more prefs stuff tomorrow.
(In reply to :Gijs (under the weather; responses will be slow) from comment #13)
> (In reply to Dão Gottwald [::dao] from comment #12)
> > These should all be unused: browser.newtabpage.enhanced,
> > browser.newtabpage.compact, browser.newtabpage.thumbnailPlaceholder
> 
> Yes, I was just looking at that - unfortunately it's not that simple,
> because of the NewTabUtils in toolkit, which AS implicitly still calls into,
> and which rely on the 'enhanced' pref, at least. I'll look at cleaning out
> more prefs stuff tomorrow.

Meh, decided to give this a go tonight.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d235fb4cb1e29577cc24d58678d5e18097525d5
Comment on attachment 8956639 [details]
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

https://reviewboard.mozilla.org/r/225600/#review231512

::: browser/app/profile/firefox.js:1262
(Diff revision 1)
>  pref("browser.newtab.preload", true);
>  
>  // Remembers if the about:newtab intro has been shown
>  // NOTE: This preference is unused but was not removed in case
>  //       this information will be valuable in the future.
>  pref("browser.newtabpage.introShown", false);

We should remove this too. If modified, it will stick around anyway unless we explicitly remove that.
Attachment #8956639 - Flags: review?(dao+bmo) → review+
Comment on attachment 8956615 [details]
Bug 1433133 - remove shared menu check icons which are now unused,

https://reviewboard.mozilla.org/r/225556/#review231584
Attachment #8956615 - Flags: review?(florian) → review+
Comment on attachment 8956614 [details]
Bug 1433133 - remove old about:newtab code,

https://reviewboard.mozilla.org/r/225554/#review231602
Attachment #8956614 - Flags: review?(florian) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc80dd3e4fae
remove old about:newtab code, r=florian
https://hg.mozilla.org/integration/autoland/rev/bb253b9ae3a2
remove shared menu check icons which are now unused, r=florian
https://hg.mozilla.org/integration/autoland/rev/bdffa40b603a
remove unused prefs and exported bits from NewTabUtils.jsm, r=dao
https://hg.mozilla.org/mozilla-central/rev/fc80dd3e4fae
https://hg.mozilla.org/mozilla-central/rev/bb253b9ae3a2
https://hg.mozilla.org/mozilla-central/rev/bdffa40b603a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Blocks: 1097056
Blocks: 1243103
Blocks: 1119906
Blocks: 964358
Blocks: 1271177
Blocks: 1151820
Blocks: 1260958
Blocks: 1064508
Blocks: 1243398
Blocks: 1370167
Blocks: 1394963
Blocks: 1089368
Blocks: 1075217
Blocks: 938163
Blocks: 1329955
Iteration: 61.1 - Mar 26 → 60.4 - Mar 12
Whiteboard: [AS61MVP]
Ato, based on:

(In reply to Andreas Tolfsen ‹:ato› from bug 1352497 comment #59)
> Note that this patch removed the
> datareporting.healthreport.about.reportUrl pref from various automation
> tools in the tree that targets release channels out-of-tree.
> This change should not have been made without approval from a
> peer of the Testing component.  I’m remedying this as part of
> https://bugzilla.mozilla.org/show_bug.cgi?id=1401129.

Do some of the unused prefs removed in the 3rd cset here need to be resurrected as part of the various marionette/geckodriver'y things as well? Apologies for missing a review here - it's not obvious to me that the lists in those files are used with other copies of Firefox (and it's not clear to me if those copies are so old that they will still be running non-activity-stream newtab or not).
Flags: needinfo?(ato)
I am resurrecting browser.newtabpage.introShown as part of
https://bugzilla.mozilla.org/show_bug.cgi?id=1401129.

Because it is unclear what files we can change and not change
preferences in, I’m also adding a visible comment to these files.
Flags: needinfo?(ato)
Depends on: 1444579
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.