1433145 - Handle unexpected alerts when switching tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1433145 -Handle unexpected alerts when switching tests,

Review commit: https://reviewboard.mozilla.org/r/215652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215652/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8945505 [details]
Bug 1433145 -Handle unexpected alerts when switching tests,

https://reviewboard.mozilla.org/r/215652/#review221324

::: commit-message-5a87f:1
(Diff revision 1)
> +Bug 1433145 -Handle unexpected alerts when switching tests, r=ato

Space after dash.

::: testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py:161
(Diff revision 1)
>              # wrong since we reload the runner in that tab anyway.
>              runner_handle = handles.pop(0)
>  
>          for handle in handles:
>              try:
> +                self.dismiss_alert(lambda:self.marionette.switch_to_window(handle))

Space after colon.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f5ee77b7511
Handle unexpected alerts when switching tests, r=ato

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8f5ee77b7511