1433172 - Drop the pref that controls the policy engine

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

Currently, the policy engine is turned off behind a pref: browser.policies.enabled

To release the engine we should remove this pref and make it unconditionally enabled, because a user shouldn't be able to disable it.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1433172 - Drop the pref that controls the policy engine.

The policy engine should always be enabled, with no way to disable it.

Review commit: https://reviewboard.mozilla.org/r/224010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224010/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Note: we decided to wait a little bit before dropping this pref. For now, we'll toggle it to true to allow early testing on Nightly and Beta, through bug 1442759

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8954857 [details]
Bug 1433172 - Drop the pref that controls the policy engine.

Dropping request for now

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8954857 [details]
Bug 1433172 - Drop the pref that controls the policy engine.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224010/diff/1-2/

Comment 5

[:Felipe Gomes (needinfo for replies!)]

The timeline for the #define EARLY_BETA_OR_EARLIER is ending soon on this cycle, so it's time to fully drop the pref now. The policy engine has been enabled by default on Nightly for about 3 weeks, and on beta 60 since the beginning of the beta cycle.

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8954857 [details]
Bug 1433172 - Drop the pref that controls the policy engine.

https://reviewboard.mozilla.org/r/224010/#review236716

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d13aee6372bf
Drop the pref that controls the policy engine. r=mossop

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d13aee6372bf

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8954857 [details]
Bug 1433172 - Drop the pref that controls the policy engine.

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise policies
[User impact if declined]: This is needed to release enterprise policies and to keep them active on beta. Right now they are conditioned to EARLY_BETA_OR_EARLIER, which this patch removes
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It will just keep the enterprise policies active
[String changes made/needed]: none

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8954857 [details]
Bug 1433172 - Drop the pref that controls the policy engine.

I'm about to flip the early beta flag, so that's timely.  beta60+, should be in 60.0b8.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/797a21d3bca6