1433211 - Fix comm-central idl definitions to work with rust binding generation.

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Tom Prince [:tomprince]]

Bug 1293362 introduced automatic generation of rustbindings for xpcom interfaces. comm-central's idl files cause the generated rust to fail to build.

Comment 1

[Phabricator Automation]

Attachment: Bug 1433211: Remove unused `purpleIProxyInfo`.

Comment 2

[Phabricator Automation]

Attachment: Bug 1433211: Remove unused `nsMsgSearchType`.

Comment 3

[:aceman]

Comment on attachment 8945559 [details]
Bug 1433211: Don't redefine `imapMessageFlagsType` in idl.

Would this work as "interface nsIImapUrl;" instead of #include?

Comment 4

[Tom Prince [:tomprince]]

(In reply to :aceman from comment #3) 
> Comment on attachment 8945559 [details]
> Bug 1433211: Don't redefine `imapMessageFlagsType` in idl.
> 
> Would this work as "interface nsIImapUrl;" instead of #include?

No. The include is to get the typedef for `imapMessageFlagsType` not `nsIImapUrl`. The problem with just having the typdef there is that rust generates the typedef twice, which cause the build to fail.

Comment 5

[Phabricator Automation]

Comment on attachment 8945555 [details]
Bug 1433211: Remove unused `purpleIProxyInfo`.

Florian Quèze [:florian] has approved the revision.

https://phabricator.services.mozilla.com/D437#10415

Comment 6

[:aceman]

I'll build with this locally and review the other patches, as they are mostly syntactic only.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8945560 [details]
Bug 1433211: Remove unused `nsMsgSearchType`.

Seems to compile and work without it ;-)
Plus, it was an awful hack, have the attribute readonly and declare a setter anyway.

Great job getting all this sorted out, please land asap.

Comment 8

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #6)
> I'll build with this locally and review the other patches, as they are
> mostly syntactic only.
Maybe my r+ is sufficient since we don't want to wait three hours for Aceman's build to finish :-(

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fade6344322e
Remove unused `purpleIProxyInfo`; r=florian
https://hg.mozilla.org/comm-central/rev/e34f8c36ca9e
Remove unused `nsMsgSearchType`; r=jorgk
https://hg.mozilla.org/comm-central/rev/00b0d2631cc2
Use `native` in idl for concrete types that are references but not defined in idl; r=jorgk
https://hg.mozilla.org/comm-central/rev/2b56d89a8792
Don't redefine `imapMessageFlagsType` in idl; r=jorgk

Comment 10

[Phabricator Automation]

Comment on attachment 8945560 [details]
Bug 1433211: Remove unused `nsMsgSearchType`.

Jorg K (GMT+1) has been removed from the revision.

https://phabricator.services.mozilla.com/D438

Comment 11

[Phabricator Automation]

Comment on attachment 8945558 [details]
Bug 1433211: Use `native` in idl for concrete types that are references but not defined in idl.

Jorg K (GMT+1) has been removed from the revision.

https://phabricator.services.mozilla.com/D439

Comment 12

[Phabricator Automation]

Comment on attachment 8945559 [details]
Bug 1433211: Don't redefine `imapMessageFlagsType` in idl.

Jorg K (GMT+1) has been removed from the revision.

https://phabricator.services.mozilla.com/D440

Comment 13

[Jorg K (CEST = GMT+2)]

Comment on attachment 8945558 [details]
Bug 1433211: Use `native` in idl for concrete types that are references but not defined in idl.

It was good last time I approved it ;-)