Closed
Bug 1433212
Opened 6 years ago
Closed 6 years ago
In-page reordering of sections
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: Mardak, Assigned: rrosario)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [AS60MVP])
Attachments
(1 file)
uiwanted: There were some mocks with a context menu for each section?
Updated•6 years ago
|
Whiteboard: [AS60MVP]
Comment 1•6 years ago
|
||
Trello card with InVision Spec: https://trello.com/c/iVCSnL9K/162-i-want-to-be-able-to-re-order-my-sections-on-new-tab
Reporter | ||
Updated•6 years ago
|
Whiteboard: [AS60MVP] → [strings needed][AS60MVP]
Reporter | ||
Comment 2•6 years ago
|
||
uiwanted: https://mozilla.invisionapp.com/share/7JFPNDEMRYC#/screens/279862272_Section_Menus_On_New_Tab_Explainer shows "^ Move Up" for Top Sites even though it's already the top section.. Although search box and manual migration are above it (but they're currently not considered sections as they don't have a context menu either). Should the option not be shown or grayed out or just leave normal when at the top/bottom-most section? strings for "Move Up" / "Move Down" landed as part of bug 1422079.
Depends on: 1422079
Whiteboard: [strings needed][AS60MVP] → [AS60MVP]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → rrosario
Assignee | ||
Updated•6 years ago
|
Priority: P2 → P1
Reporter | ||
Comment 3•6 years ago
|
||
Trying to summarize what we discussed: We'll have a comma-separated list of section names in a pref. Ensure the pref contains a section when it's added. Ensure "topsites" is first if not in the list. Have <Sections> manage where to render <TopSites> instead of Base component. Sections component refers to the pref to sort [topsites, other sections] to then render in appropriate order. Move up/down needs to be aware of which sections are enabled or not, and move past the next visible section.
Reporter | ||
Comment 4•6 years ago
|
||
uifeedback: Gray out the options if it can't be used. What grey-# to use? Hrmm..
Keywords: uiwanted
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Ed Lee :Mardak (PTO-Mar18) from comment #4) > uifeedback: Gray out the options if it can't be used. What grey-# to use? > Hrmm.. I showed Aaron a screenshot with `opacity: 0.4;` and he approved.
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/cd2d5031f7cf6212480a6026b8418253d519b902 Fix Bug 1433212 - Implement section reordering https://github.com/mozilla/activity-stream/commit/7536b339113448ab099b139cc6873076cfe8f1d1 Merge pull request #4022 from rlr/Bug1433212/section-reordering Fix Bug 1433212 - Implement section reordering
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9e902a91c375
Target Milestone: --- → Firefox 60
Reporter | ||
Updated•6 years ago
|
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•