Closed Bug 1433212 Opened 6 years ago Closed 6 years ago

In-page reordering of sections

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Iteration:
60.4 - Mar 12
Tracking Status
firefox60 --- fixed

People

(Reporter: Mardak, Assigned: rrosario)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [AS60MVP])

Attachments

(1 file)

uiwanted: There were some mocks with a context menu for each section?
Whiteboard: [AS60MVP]
Whiteboard: [AS60MVP] → [strings needed][AS60MVP]
uiwanted: https://mozilla.invisionapp.com/share/7JFPNDEMRYC#/screens/279862272_Section_Menus_On_New_Tab_Explainer shows "^ Move Up" for Top Sites even though it's already the top section.. Although search box and manual migration are above it (but they're currently not considered sections as they don't have a context menu either). Should the option not be shown or grayed out or just leave normal when at the top/bottom-most section?

strings for "Move Up" / "Move Down" landed as part of bug 1422079.
Depends on: 1422079
Whiteboard: [strings needed][AS60MVP] → [AS60MVP]
Assignee: nobody → rrosario
Priority: P2 → P1
Trying to summarize what we discussed:

We'll have a comma-separated list of section names in a pref.
Ensure the pref contains a section when it's added.
Ensure "topsites" is first if not in the list.
Have <Sections> manage where to render <TopSites> instead of Base component.
Sections component refers to the pref to sort [topsites, other sections] to then render in appropriate order.
Move up/down needs to be aware of which sections are enabled or not, and move past the next visible section.
uifeedback: Gray out the options if it can't be used. What grey-# to use? Hrmm..
Keywords: uiwanted
(In reply to Ed Lee :Mardak (PTO-Mar18) from comment #4)
> uifeedback: Gray out the options if it can't be used. What grey-# to use?
> Hrmm..

I showed Aaron a screenshot with `opacity: 0.4;` and he approved.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1443928
Blocks: 1444980
Depends on: 1454743
Blocks: 1454743
No longer depends on: 1454743
Blocks: 1484199
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.