1433229 - Move view related functions into calViewUtils.jsm

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Using the script from attachment 8942466 [details] [diff] [review] (which has r+) and the following migrations:

cal.isMouseOverBox                   -> cal.view.isMouseOverBox
cal.calRadioGroupSelectItem          -> cal.view.radioGroupSelectItem
cal.applyAttributeToMenuChildren     -> cal.view.applyAttributeToMenuChildren
cal.removeChildElementsByAttribute   -> cal.view.removeChildElementsByAttribute
cal.getParentNodeOrThis              -> cal.view.getParentNodeOrThis
cal.getParentNodeOrThisByAttribute   -> cal.view.getParentNodeOrThisByAttribute
cal.formatStringForCSSRule           -> cal.view.formatStringForCSSRule
cal.getCompositeCalendar             -> cal.view.getCompositeCalendar
cal.hashColor                        -> cal.view.hashColor
cal.getContrastingTextColor          -> cal.view.getContrastingTextColor


I'd like to move ACL functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This is the next set of patches after bug 1433156.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Manual Changes - v1

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Automatic Changes - v1

Comment 3

[Martin Schröder [:mschroeder]]

Please have a look at bug 1399842 where I move two of the functions inline because they use "document".

Comment 4

[[:MakeMyDay]]

Comment on attachment 8945568 [details] [diff] [review]
Manual Changes - v1

Review of attachment 8945568 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. r+ provided a green try push.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fb1b8835b794f1ac94a15ba37db53f2b7595ac57

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Working try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0252aca9f4f60703c9ab7a50649c29b19c50f2a7

For checkin, please push the manual and the automatic patches, in that order.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/033ede986813
Move view related functions into calViewUtils.jsm - manual changes. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/850b32c6652c
Move view related functions into calViewUtils.jsm - automatic changes. r=MakeMyDay