Closed Bug 1433229 Opened 4 years ago Closed 4 years ago

Move view related functions into calViewUtils.jsm

Categories

(Calendar :: Internal Components, defect)

Lightning 6.2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(2 files)

Using the script from attachment 8942466 [details] [diff] [review] (which has r+) and the following migrations:

cal.isMouseOverBox                   -> cal.view.isMouseOverBox
cal.calRadioGroupSelectItem          -> cal.view.radioGroupSelectItem
cal.applyAttributeToMenuChildren     -> cal.view.applyAttributeToMenuChildren
cal.removeChildElementsByAttribute   -> cal.view.removeChildElementsByAttribute
cal.getParentNodeOrThis              -> cal.view.getParentNodeOrThis
cal.getParentNodeOrThisByAttribute   -> cal.view.getParentNodeOrThisByAttribute
cal.formatStringForCSSRule           -> cal.view.formatStringForCSSRule
cal.getCompositeCalendar             -> cal.view.getCompositeCalendar
cal.hashColor                        -> cal.view.hashColor
cal.getContrastingTextColor          -> cal.view.getContrastingTextColor


I'd like to move ACL functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This is the next set of patches after bug 1433156.
Attachment #8945568 - Flags: review?(makemyday)
Please have a look at bug 1399842 where I move two of the functions inline because they use "document".
Comment on attachment 8945568 [details] [diff] [review]
Manual Changes - v1

Review of attachment 8945568 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. r+ provided a green try push.
Attachment #8945568 - Flags: review?(makemyday) → review+
Working try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0252aca9f4f60703c9ab7a50649c29b19c50f2a7

For checkin, please push the manual and the automatic patches, in that order.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/033ede986813
Move view related functions into calViewUtils.jsm - manual changes. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/850b32c6652c
Move view related functions into calViewUtils.jsm - automatic changes. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.2
You need to log in before you can comment on or make changes to this bug.