Closed Bug 1433234 Opened 3 years ago Closed 3 years ago

Replace do_check_array_eq by Assert.deepEqual

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: eoger, Assigned: u602518, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Comment on attachment 8946074 [details]
Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.

https://reviewboard.mozilla.org/r/216108/#review221868

Hi Vinicus,

Thank you for your contribution. This looks great!
Can we also remove the function definition in |https://searchfox.org/mozilla-central/rev/674c27a54e593abbfe39cfa7edea489f6f89b8c2/services/sync/tests/unit/head_helpers.js#272|?
Attachment #8946074 - Flags: review?(eoger)
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Assignee: eoger → viniciuscosta0197
(In reply to Edouard Oger [:eoger] from comment #2)
> Comment on attachment 8946074 [details]
> Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.
> 
> https://reviewboard.mozilla.org/r/216108/#review221868
> 
> Hi Vinicus,
> 
> Thank you for your contribution. This looks great!
> Can we also remove the function definition in
> |https://searchfox.org/mozilla-central/rev/
> 674c27a54e593abbfe39cfa7edea489f6f89b8c2/services/sync/tests/unit/
> head_helpers.js#272|?

Yes, I can remove the function definition too. Should I merge the two commits?
Yup sounds good!
Comment on attachment 8946074 [details]
Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.

https://reviewboard.mozilla.org/r/216108/#review221870

Thank you!
Attachment #8946074 - Flags: review?(eoger) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e209f00a75a8
Replace do_check_array_eq by Assert.deepEqual. r=eoger
https://hg.mozilla.org/mozilla-central/rev/e209f00a75a8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.