Closed
Bug 1433234
Opened 3 years ago
Closed 3 years ago
Replace do_check_array_eq by Assert.deepEqual
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: eoger, Assigned: u602518, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
This should be pretty straightforward: https://searchfox.org/mozilla-central/search?q=do_check_array_eq&case=false®exp=false&path=services
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 2•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8946074 [details] Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual. https://reviewboard.mozilla.org/r/216108/#review221868 Hi Vinicus, Thank you for your contribution. This looks great! Can we also remove the function definition in |https://searchfox.org/mozilla-central/rev/674c27a54e593abbfe39cfa7edea489f6f89b8c2/services/sync/tests/unit/head_helpers.js#272|?
Attachment #8946074 -
Flags: review?(eoger)
|
|
Reporter | |
Updated•3 years ago
|
Assignee: nobody → eoger
Status: NEW → ASSIGNED
|
|
Reporter | |
Updated•3 years ago
|
Assignee: eoger → viniciuscosta0197
|
|
Reporter | |
Comment 3•3 years ago
|
||
I've pushed your patch on try also: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85de65867c22318c70f866e51f71e64125f6319f
(In reply to Edouard Oger [:eoger] from comment #2) > Comment on attachment 8946074 [details] > Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual. > > https://reviewboard.mozilla.org/r/216108/#review221868 > > Hi Vinicus, > > Thank you for your contribution. This looks great! > Can we also remove the function definition in > |https://searchfox.org/mozilla-central/rev/ > 674c27a54e593abbfe39cfa7edea489f6f89b8c2/services/sync/tests/unit/ > head_helpers.js#272|? Yes, I can remove the function definition too. Should I merge the two commits?
|
|
Reporter | |
Comment 5•3 years ago
|
||
Yup sounds good!
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 7•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8946074 [details] Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual. https://reviewboard.mozilla.org/r/216108/#review221870 Thank you!
Attachment #8946074 -
Flags: review?(eoger) → review+
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e209f00a75a8 Replace do_check_array_eq by Assert.deepEqual. r=eoger
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e209f00a75a8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•