1433234 - Replace do_check_array_eq by Assert.deepEqual

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Edouard Oger [:eoger]]

This should be pretty straightforward:
https://searchfox.org/mozilla-central/search?q=do_check_array_eq&case=false&regexp=false&path=services

Comment 1

[u602518]

Attachment: Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.

Review commit: https://reviewboard.mozilla.org/r/216108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216108/

Comment 2

[Edouard Oger [:eoger]]

Comment on attachment 8946074 [details]
Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.

https://reviewboard.mozilla.org/r/216108/#review221868

Hi Vinicus,

Thank you for your contribution. This looks great!
Can we also remove the function definition in |https://searchfox.org/mozilla-central/rev/674c27a54e593abbfe39cfa7edea489f6f89b8c2/services/sync/tests/unit/head_helpers.js#272|?

Comment 3

[Edouard Oger [:eoger]]

I've pushed your patch on try also:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85de65867c22318c70f866e51f71e64125f6319f

Comment 4

[u602518]

(In reply to Edouard Oger [:eoger] from comment #2)
> Comment on attachment 8946074 [details]
> Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.
> 
> https://reviewboard.mozilla.org/r/216108/#review221868
> 
> Hi Vinicus,
> 
> Thank you for your contribution. This looks great!
> Can we also remove the function definition in
> |https://searchfox.org/mozilla-central/rev/
> 674c27a54e593abbfe39cfa7edea489f6f89b8c2/services/sync/tests/unit/
> head_helpers.js#272|?

Yes, I can remove the function definition too. Should I merge the two commits?

Comment 5

[Edouard Oger [:eoger]]

Yup sounds good!

Comment 6

[u602518]

Comment on attachment 8946074 [details]
Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216108/diff/1-2/

Comment 7

[Edouard Oger [:eoger]]

Comment on attachment 8946074 [details]
Bug 1433234 - Replace do_check_array_eq by Assert.deepEqual.

https://reviewboard.mozilla.org/r/216108/#review221870

Thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e209f00a75a8
Replace do_check_array_eq by Assert.deepEqual. r=eoger

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e209f00a75a8