1433290 - Remove Block parameter for InstallAddons and Popup policies

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Abe - QA (:Abe_LV)]

Steps to reproduce:
1. Use latest nightly that have patch from Bug 1428922
2. Set policies.json as:
  {
  "policies": {
    "install_addons": {
      "allow": [      
     
      ],
      "block": [            
           "https://duckduckgo.com",
      
      ]
    }
  }
}

3. Go to  https://duckduckgo.com/ and click "DuckDuckGo to Firefox"

Expected Result:
It should not install the addon while a blockpolicy is in use.

Actual Result:
It installs the addon.

Comment 1

[Abe - QA (:Abe_LV)]

Correction
Remove the comma after the URL in the policy (in comment 0).
Or use the following.
{
  "policies": {
    "install_addons": {
      "allow": [      
     
      ],
      "block": [            
           "https://duckduckgo.com"
      
      ]
    }
  }
}

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Note: this bug will be resolved before the engine rolls out, by removing support for the "Block" part of this policy, since it doesn't make sense in our UI.  Only a preset "Allow" for installing add-ons make sense.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1433290 - Remove Block parameter for InstallAddons and Popup policies.

The Block parameters for the InstallAddons policy doesn't make sense because the addons install process has two behaviors:
- Allow
- Ask

So a website that is not explictly in the allow list will always ask for permission before installing an addon. If a sysadmin wants to fully block addon install they can use a different policy.

Similarly, for Popups it's the same thing. There is a conceptually valid use case in that someone can change the _default_ behavior to always allow popups, and then the Block list becomes the allow exceptions to Ask. But that's a corner case that we don't need to support now, since allowing popups globally on the web is a pretty crazy choice.

Review commit: https://reviewboard.mozilla.org/r/223292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223292/

Comment 4

[Robin Steuber (they/them) [:bytesized]]

Comment on attachment 8954143 [details]
Bug 1433290 - Remove Block parameter for InstallAddons and Popup policies.

https://reviewboard.mozilla.org/r/223292/#review229338

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d5ae4b0b826
Remove Block parameter for InstallAddons and Popup policies. r=bytesized

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1d5ae4b0b826

Comment 7

[Abe - QA (:Abe_LV)]

This is just a code change.