Closed
Bug 1433336
Opened 6 years ago
Closed 6 years ago
Don't collect all descendants documents for intersection observer in nsRefreshDriver
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(3 files)
We are enumerating all descendants but we just need documents that are observed by IntersectionObserver. https://hg.mozilla.org/mozilla-central/file/b5b38db26ed7/layout/base/nsRefreshDriver.cpp#l1582 https://treeherder.mozilla.org/#/jobs?repo=try&revision=c54c77f25ab193b8aa9958a642451463d685fa99
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8945670 [details] Bug 1433336 - Drop unused SubDocEnumArgs in nsDocument.cpp. https://reviewboard.mozilla.org/r/215806/#review221610
Attachment #8945670 -
Flags: review?(bugs) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8945671 [details] Bug 1433336 - Add nsIDocument::CollectDescendantDocument(). https://reviewboard.mozilla.org/r/215808/#review221612 ::: dom/base/nsIDocument.h:1920 (Diff revision 1) > typedef bool (*nsSubDocEnumFunc)(nsIDocument *aDocument, void *aData); > virtual void EnumerateSubDocuments(nsSubDocEnumFunc aCallback, > void *aData) = 0; > > /** > + * Collect descendant documents that the |aCalback| returns true for the Maybe: Collect all the descendant documents for which |aCallback| returns true.
Attachment #8945671 -
Flags: review?(bugs) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8945672 [details] Bug 1433336 - Collect only documents which are observerd by IntersectionObserver in nsRefreshDriver::Tick(). https://reviewboard.mozilla.org/r/215810/#review221618
Attachment #8945672 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•6 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #5) > Comment on attachment 8945671 [details] > Bug 1433336 - Add nsIDocument::CollectDescendantDocument(). > > https://reviewboard.mozilla.org/r/215808/#review221612 > > ::: dom/base/nsIDocument.h:1920 > (Diff revision 1) > > typedef bool (*nsSubDocEnumFunc)(nsIDocument *aDocument, void *aData); > > virtual void EnumerateSubDocuments(nsSubDocEnumFunc aCallback, > > void *aData) = 0; > > > > /** > > + * Collect descendant documents that the |aCalback| returns true for the > > Maybe: Collect all the descendant documents for which |aCallback| returns > true. Thanks. :)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•6 years ago
|
||
A final try; https://treeherder.mozilla.org/#/jobs?repo=try&revision=08ac90c040abdb6963a948929be742531b98dc58
Comment 12•6 years ago
|
||
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2284c3fb5ccb Drop unused SubDocEnumArgs in nsDocument.cpp. r=smaug https://hg.mozilla.org/integration/autoland/rev/10a71ed46d4d Add nsIDocument::CollectDescendantDocument(). r=smaug https://hg.mozilla.org/integration/autoland/rev/a7b31b61e096 Collect only documents which are observerd by IntersectionObserver in nsRefreshDriver::Tick(). r=smaug
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2284c3fb5ccb https://hg.mozilla.org/mozilla-central/rev/10a71ed46d4d https://hg.mozilla.org/mozilla-central/rev/a7b31b61e096
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•