Closed
Bug 1433396
Opened 6 years ago
Closed 6 years ago
Remove feature to submit crash reports from infobar in beta
Categories
(Toolkit :: Crash Reporting, enhancement)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: marco, Assigned: philipp)
Details
Attachments
(1 file)
1.25 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
We only have this feature enabled in early beta, which means we can't analyze trends so easily. All the tools are ignoring these crashes, by querying Socorro with submitted_from_infobar==false. For every new Beta release, we stress the Socorro servers (at first, we even had problems scaling the infrastructure) with a lot of crash reports (all those queued during the late beta period). We remind users of crashes and shutdown crashes that maybe they wouldn't have noticed. Given the points above, I think we should disable this during early Beta too and only keep it enabled in Nightly, where it can provide real value.
Assignee | ||
Comment 1•6 years ago
|
||
this is a presumptive patch for disabling the infobar on beta
Comment 2•6 years ago
|
||
Ted, can you take a look? Who might be a good reviewer for Philipp's patch?
Flags: needinfo?(ted)
Comment 4•6 years ago
|
||
Mike would you mind looking over philipp's patch? It would be handy if we could get this into 60 before Thursday's merge.
status-firefox60:
--- → affected
Flags: needinfo?(mconley)
Comment 5•6 years ago
|
||
Comment on attachment 8946422 [details] [diff] [review] bug1433396.patch Yeah, I'm fine with this. Based on what I've heard, the crash reports submitting by this thing on early beta are more of a nuisance than they are useful. Hopefully nobody is super-depending on this stuff.
Flags: needinfo?(mconley)
Attachment #8946422 -
Flags: review+
Assignee | ||
Comment 6•6 years ago
|
||
great, thanks! in my experience this is causing mostly confusion/detraction after each new beta cycle as well - i'm not aware of any valuable insight those reports would have provided to date.
Keywords: checkin-needed
Updated•6 years ago
|
Assignee: nobody → madperson
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0a9a2976d79 Restrict infobar about unsubmitted crashes to Nightly builds. r=mconley
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c0a9a2976d79
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•