Closed Bug 1433406 Opened 2 years ago Closed 2 years ago

[MIPS32] - Simplify 64-bit arithmetics

Categories

(Core :: JavaScript Engine: JIT, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: milan.knezevic, Assigned: milan.knezevic)

References

Details

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 OPR/50.0.2762.67
Attached patch 64bit-arithmetics_26012018.diff (obsolete) — Splinter Review
Make 64-bit arithmetics on Mips32 less branchy.
Depends on: wasm-mips
Luke, would you please select a reviewer?
Flags: needinfo?(luke)
Severity: normal → enhancement
Priority: -- → P5
Comment on attachment 8945742 [details] [diff] [review]
64bit-arithmetics_26012018.diff

Review of attachment 8945742 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8945742 - Flags: review+
Flags: needinfo?(luke)
Keywords: checkin-needed
There were conflicts while landing the patch.
Flags: needinfo?(milan.knezevic)
Keywords: checkin-needed
Sorry, dependencies are not landed yet. This bug depends on Bug 1284414.
Flags: needinfo?(milan.knezevic)
Attached patch 64bit-arithmetics.diff (obsolete) — Splinter Review
Attachment #8945742 - Attachment is obsolete: true
Attachment #8952707 - Flags: review+
Keywords: checkin-needed
Assignee: nobody → milan.knezevic
Attachment #8952707 - Attachment is obsolete: true
Attachment #8952733 - Flags: review+
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5b71b35fd1f
[MIPS32] - Simplify 64-bit arithmetics. r=luke
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a5b71b35fd1f
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.