[MIPS32] - Simplify 64-bit arithmetics

RESOLVED FIXED in Firefox 60

Status

()

P5
enhancement
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: milan.knezevic, Assigned: milan.knezevic)

Tracking

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

a year ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 OPR/50.0.2762.67
(Assignee)

Comment 1

a year ago
Created attachment 8945742 [details] [diff] [review]
64bit-arithmetics_26012018.diff

Make 64-bit arithmetics on Mips32 less branchy.
(Assignee)

Updated

a year ago
Depends on: 1284414
Luke, would you please select a reviewer?
Flags: needinfo?(luke)
Severity: normal → enhancement
status-firefox60: --- → fix-optional
Priority: -- → P5

Comment 3

11 months ago
Comment on attachment 8945742 [details] [diff] [review]
64bit-arithmetics_26012018.diff

Review of attachment 8945742 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8945742 - Flags: review+

Updated

11 months ago
Flags: needinfo?(luke)
(Assignee)

Updated

11 months ago
Keywords: checkin-needed
There were conflicts while landing the patch.
Flags: needinfo?(milan.knezevic)
Keywords: checkin-needed
(Assignee)

Comment 5

11 months ago
Sorry, dependencies are not landed yet. This bug depends on Bug 1284414.
Flags: needinfo?(milan.knezevic)
(Assignee)

Comment 6

11 months ago
Created attachment 8952707 [details] [diff] [review]
64bit-arithmetics.diff
Attachment #8945742 - Attachment is obsolete: true
(Assignee)

Updated

11 months ago
Attachment #8952707 - Flags: review+
(Assignee)

Updated

11 months ago
Keywords: checkin-needed
Assignee: nobody → milan.knezevic
(Assignee)

Comment 7

11 months ago
Created attachment 8952733 [details] [diff] [review]
64bit-arithmetics.diff
Attachment #8952707 - Attachment is obsolete: true
Attachment #8952733 - Flags: review+

Comment 8

11 months ago
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5b71b35fd1f
[MIPS32] - Simplify 64-bit arithmetics. r=luke
Keywords: checkin-needed

Comment 9

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a5b71b35fd1f
Status: UNCONFIRMED → RESOLVED
Last Resolved: 11 months ago
status-firefox60: fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.