Closed Bug 1433417 Opened 2 years ago Closed 2 years ago

Fix a bunch of typo in the doc

Categories

(Developer Documentation :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

Fixed automatically thanks to codespell
Comment on attachment 8945747 [details]
Bug 1433417 - Fix a bunch of typo in the doc

https://reviewboard.mozilla.org/r/215856/#review221742

Looks great, thanks! Excited to see this running, will save a lot of reviewer time.

::: commit-message-0a432:1
(Diff revision 1)
> +Bug 1433417 - Fix a bunch of typo in the doc r?ahal

This picked up a bunch of third_party docs. I guess fixing external docs isn't that bad, but maybe it's best to just remove those changes. Looks like files under the following paths are 3rd party:

- testing/mozharness/external_tools
- testing/web-platform/tests/tools/six
- testing/web-platform/tests/tools/third_party
- third_party

::: mobile/android/docs/shutdown.rst:30
(Diff revision 1)
>  shutdown as well, so as to
>  
>  1) provide an immediate visual feedback to the user that Firefox is indeed quitting
>  
>  2) avoid a state where the UI is still running "normally" while the rendering engine is already
> -   shutting down, which could lead to loosing incoming external tabs if they were to arrive within
> +   shutting down, which could lead to losing incoming external tabs if they were to arrive within

Yes! This is my pet peeve.
Attachment #8945747 - Flags: review?(ahalberstadt) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f1a5068af92
Fix a bunch of typo in the doc r=ahal
https://hg.mozilla.org/mozilla-central/rev/4f1a5068af92
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.