Closed
Bug 1433545
Opened 6 years ago
Closed 6 years ago
Add scriptURL string to ServiceWorkerDescriptor
Categories
(Core :: DOM: Service Workers, enhancement, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(2 files)
6.89 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
4.55 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
I forgot to add the scriptURL field in bug 1412858. We don't need it yet, but we will for bug 1429200.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e74504662a93497feaf411de95b7152fc255ce78
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8946418 [details] [diff] [review] P1 Add scriptURL to ServiceWorkerDescriptor. r=asuth Add the script URL to the ServiceWorkerDescriptor.
Attachment #8946418 -
Flags: review?(bugmail)
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8946419 [details] [diff] [review] P2 Remove mScriptSpec from ServiceWorkerInfo and use mDescriptor.ScriptURL() instead. r=asuth This removes the ServiceWorkerInfo::mScriptSpec member in favor of using mDescriptor.ScriptURL() instead.
Attachment #8946419 -
Flags: review?(bugmail)
Updated•6 years ago
|
Attachment #8946418 -
Flags: review?(bugmail) → review+
Updated•6 years ago
|
Attachment #8946419 -
Flags: review?(bugmail) → review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9be09d7a6297 P1 Add scriptURL to ServiceWorkerDescriptor. r=asuth https://hg.mozilla.org/integration/mozilla-inbound/rev/a1b1e70fd362 P2 Remove mScriptSpec from ServiceWorkerInfo and use mDescriptor.ScriptURL() instead. r=asuth
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9be09d7a6297 https://hg.mozilla.org/mozilla-central/rev/a1b1e70fd362
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•