Update webrender to b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kats, Assigned: kats)

Tracking

(Blocks 2 bugs)

60 Branch
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1432789 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Bustage was from some #[cfg] statements added in servo/webrender#2359, specifically these:

https://github.com/servo/webrender/blob/b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3/webrender/src/capture.rs#L28
https://github.com/servo/webrender/blob/b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3/webrender/src/renderer.rs#L2321
https://github.com/servo/webrender/blob/b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3/webrender/src/renderer.rs#L2323

Since these don't actually affect the generated FFI header I'll just comment them out locally when generating the header but it would be nice to fix cbindgen/syn to support this.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3
Version: unspecified → 60 Branch
Comment hidden (mozreview-request)

Comment 10

a year ago
mozreview-review
Comment on attachment 8946670 [details]
Bug 1433567 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/216644/#review222380
Attachment #8946670 - Flags: review?(jmuizelaar) → review+

Comment 11

a year ago
mozreview-review
Comment on attachment 8946669 [details]
Bug 1433567 - Update webrender to commit b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3.

https://reviewboard.mozilla.org/r/216642/#review222370
Attachment #8946669 - Flags: review?(jmuizelaar) → review+

Comment 12

a year ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c95a19decb5
Update webrender to commit b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/48cdd6912ed6
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/0c95a19decb5
https://hg.mozilla.org/mozilla-central/rev/48cdd6912ed6
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1434643
No longer depends on: 1434643
This improved our build times on Windows!

== Change summary for alert #11341 (as of Tue, 30 Jan 2018 14:04:19 GMT) ==

Improvements:

  5%  build times windows2012-32 opt static-analysis taskcluster-c4.4xlarge     2,262.50 -> 2,152.64
  5%  build times windows2012-64 opt static-analysis taskcluster-c4.4xlarge     2,392.04 -> 2,276.16

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11341
You need to log in before you can comment on or make changes to this bug.