Closed Bug 1433568 Opened 3 years ago Closed 3 years ago
remove default empty constructor from Service
In bug 1412858 I included a ServiceWorkerDescriptor() constructor that initializes a somewhat bogus IPCServiceWorkerDescriptor. It appears we don't need it. Let's remove it.
Comment on attachment 8945898 [details] [diff] [review] Remove the empty ServiceWorkerDescriptor() constructor. r=asuth Andrew, this removes a dubious default constructor from ServiceWorkerDescriptor(). It was mainly there so I could initialize ServiceWorkerInfo::mDescriptor as default and then overwrite it after I had a chance to call PrincpalToPrincipalInfo(). This patch just makes the ServiceWorkerDescriptor constructor do the principal conversion instead. In general we don't want uninitialized ServiceWorkerDescriptor objects running around the system.
Attachment #8945898 - Flags: review?(bugmail)
Attachment #8945898 - Flags: review?(bugmail) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/873831981ed8 Remove the empty ServiceWorkerDescriptor() constructor. r=asuth
You need to log in before you can comment on or make changes to this bug.