Closed
Bug 1433568
Opened 6 years ago
Closed 6 years ago
remove default empty constructor from ServiceWorkerDescriptor
Categories
(Core :: DOM: Service Workers, enhancement)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
|
5.11 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
In bug 1412858 I included a ServiceWorkerDescriptor() constructor that initializes a somewhat bogus IPCServiceWorkerDescriptor. It appears we don't need it. Let's remove it.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Comment on attachment 8945898 [details] [diff] [review] Remove the empty ServiceWorkerDescriptor() constructor. r=asuth Andrew, this removes a dubious default constructor from ServiceWorkerDescriptor(). It was mainly there so I could initialize ServiceWorkerInfo::mDescriptor as default and then overwrite it after I had a chance to call PrincpalToPrincipalInfo(). This patch just makes the ServiceWorkerDescriptor constructor do the principal conversion instead. In general we don't want uninitialized ServiceWorkerDescriptor objects running around the system.
Attachment #8945898 -
Flags: review?(bugmail)
|
||
Updated•6 years ago
|
Attachment #8945898 -
Flags: review?(bugmail) → review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/873831981ed8 Remove the empty ServiceWorkerDescriptor() constructor. r=asuth
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/873831981ed8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•