1433593 - Migrate usages of MigrationUtils.importLoginWrapper to MigrationUtils.importLoginsWrapper

Status: RESOLVED FIXED

(Firefox :: Migration, enhancement, P1)

Description

[Alex Thayer [:alexical] (she/her)]

Follow-up for Bug 1426721. We still need to migrate the IE/Edge usages to use the bulk interfaces. Once they are over, we can just delete the synchronous single-login path.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin

In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

Review commit: https://reviewboard.mozilla.org/r/220600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220600/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8951352 [details]
Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin

https://reviewboard.mozilla.org/r/220600/#review226616

Thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebbcdc3e642d
Clean up usages of LoginHelper.maybeImportLogin r=MattN

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7194edc95a6e
Backed out changeset ebbcdc3e642d for X failing in toolkit/components/passwordmgr/test/unit/test_maybeImportLogin.js on a CLOSED TREE

Comment 5

[Eliza Balazs [:ebalazs_]]

Backed out changeset ebbcdc3e642d (bug 1433593) for X failing in toolkit/components/passwordmgr/test/unit/test_maybeImportLogin.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ebbcdc3e642dd03221d41dabd8fd398681a24a75&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=running&selectedJob=162554673

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=162554673&repo=autoland&lineNumber=2420

Backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7194edc95a6e3fddb782154e757e5f6b01ca1ab1&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=running

Comment 6

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1433593 - Skip test_maybeImportLogin on Android

Review commit: https://reviewboard.mozilla.org/r/220978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220978/

Comment 7

[Alex Thayer [:alexical] (she/her)]

Marking as P1 to reflect the current work status.

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8951705 [details]
Bug 1433593 - Skip test_maybeImportLogin on Android

https://reviewboard.mozilla.org/r/220978/#review227564

::: toolkit/components/passwordmgr/test/unit/xpcshell.ini:36
(Diff revision 1)
>  [test_logins_search.js]
> +skip-if = os == "android" # Only used by migrator, which isn't on Android
>  [test_maybeImportLogin.js]

I think you meant to skip test_maybeImportLogin.js. rs=me if you fix it.

Comment 9

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8951705 [details]
Bug 1433593 - Skip test_maybeImportLogin on Android

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220978/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96327b595b91
Clean up usages of LoginHelper.maybeImportLogin r=MattN
https://hg.mozilla.org/integration/autoland/rev/c1b0ea577728
Skip test_maybeImportLogin on Android r=MattN

Comment 11

[Stefan Hindli [:stefan_hindli]]

Backed out 2 changesets (bug 1433593) for xpcshell on /tests/unit/test_IE7_passwords.js on a CLOSED TREE
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f57e04801a922a8f680f892b41e6f2b4811709ca&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable
https://hg.mozilla.org/integration/autoland/rev/f57e04801a922a8f680f892b41e6f2b4811709ca

Comment 12

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8951352 [details]
Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220600/diff/1-2/

Comment 13

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8951705 [details]
Bug 1433593 - Skip test_maybeImportLogin on Android

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220978/diff/2-3/

Comment 14

[Alex Thayer [:alexical] (she/her)]

Sorry for the noise, Matt, but could you take a last glance at the changes to the first commit?

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98b7ab97db872f6eab3d454c31721babefebe565&selectedJob=163551871

Comment 15

[Matthew N. [:MattN]]

LGTM. Thanks

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00fde1af50bf
Clean up usages of LoginHelper.maybeImportLogin r=MattN
https://hg.mozilla.org/integration/autoland/rev/1aec20fe2d4e
Skip test_maybeImportLogin on Android r=MattN

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/00fde1af50bf
https://hg.mozilla.org/mozilla-central/rev/1aec20fe2d4e