1433644 - Crash in UncacheSID

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-9227b52e-63cc-48fd-94a3-cdbc60180126.
=============================================================

Top 10 frames of crashing thread:

0 libnss3.so UncacheSID security/nss/lib/ssl/sslnonce.c:375
1 libnss3.so ssl_UncacheSessionID security/nss/lib/ssl/sslnonce.c:411
2 libnss3.so ssl_BeginClientHandshake security/nss/lib/ssl/sslcon.c:173
3 libnss3.so ssl_Do1stHandshake security/nss/lib/ssl/sslsecur.c:66
4 libnss3.so SSL_ForceHandshake security/nss/lib/ssl/sslsecur.c:410
5 libxul.so nsNSSSocketInfo::DriveHandshake security/manager/ssl/nsNSSIOLayer.cpp:418
6 libxul.so mozilla::net::nsHttpConnection::EnsureNPNComplete netwerk/protocol/http/nsHttpConnection.cpp:482
7 libxul.so mozilla::net::nsHttpConnection::OnSocketWritable netwerk/protocol/http/nsHttpConnection.cpp:1827
8 libxul.so mozilla::net::nsHttpConnection::OnOutputStreamReady netwerk/protocol/http/nsHttpConnection.cpp:2358
9 libxul.so <name omitted> netwerk/protocol/http/nsHttpConnection.cpp

=============================================================

There is 1 crash (from 1 installation) in nightly 60 with buildid 20180126104610. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1432177.

[1] https://hg.mozilla.org/mozilla-central/rev?node=348b36156a84

Comment 1

[Franziskus Kiefer [:franziskus]]

Well, I'm not surprised. I'll land a hotfix for this. The real work is happening in bug 1432144.

Comment 2

[Phabricator Automation]

Comment on attachment 8946201 [details]
Bug 1433644 - sid uncache hotfix, r=mt

Tim Taubert [:ttaubert] has approved the revision.

https://phabricator.services.mozilla.com/D470#10752

Comment 3

[Franziskus Kiefer [:franziskus]]

This is only a temporary fix https://hg.mozilla.org/projects/nss/rev/1b20549e10753e82b756463dfdb597884ad39b4d