JSON Viewer may not expand nodes

VERIFIED FIXED in Firefox 59

Status

defect
P3
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

({regression})

unspecified
Firefox 60
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox58 unaffected, firefox59 verified, firefox60 verified)

Details

Attachments

(2 attachments)

Assignee

Updated

a year ago
Duplicate of this bug: 1425677
Assignee

Updated

a year ago
Duplicate of this bug: 1429271
Comment hidden (mozreview-request)
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Priority: -- → P3
Posted image jsonv.png
(In reply to Oriol Brufau [:Oriol] from comment #0)
> 1. Enable e10s
> 2. Load https://bug1394094.bmoattachments.org/attachment.cgi?id=8901438
> 3. You may need to reload the page a few times
I can't reproduce the problem.

I am attaching a screenshot showing what I am seeing after step #3.
The JSON view looks correctly expanded, right?

Honza
Flags: needinfo?(oriol-bugzilla)
Assignee

Comment 5

a year ago
OK, a more reliable way to reproduce is

<?php
header('Content-type: application/json');
$i = 0;
echo "[\n";
while($i < 10) {
  ++$i;
  echo "    [", $i, "],\n";
  ob_end_flush();
  flush();
  ob_start();
  sleep(1);
}
echo "  0\n]";
?>

You said in bug 1417039 comment 10 that you had to disable compression.
Flags: needinfo?(oriol-bugzilla)
Assignee

Comment 6

a year ago
You can also only add the test changes from my patch, and it will fail. Also add `await new Promise(() => {})` if you want to have time to check manually that the array is collapsed.
Comment hidden (Intermittent Failures Robot)
Comment on attachment 8946155 [details]
Bug 1433655 - Allow JSON Viewer to change expandedNodes state.

https://reviewboard.mozilla.org/r/216144/#review223870

Looks good, thanks!

R+ assuming try is green.


Note that I had to use the following code to test the patch:
(ob_start() called at the beggining)

<?php
header('Content-type: application/json');
$i = 0;
echo "[\n";
ob_start();
while($i < 10) {
  ++$i;
  echo "    [", $i, "],\n";
  ob_end_flush();
  flush();
  sleep(1);
}
echo "  0\n]";
?>


Honza
Attachment #8946155 - Flags: review?(odvarko) → review+
Assignee

Updated

a year ago
Keywords: checkin-needed

Comment 9

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/36a5a69f4328
Allow JSON Viewer to change expandedNodes state. r=Honza
Keywords: checkin-needed

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/36a5a69f4328
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Assignee

Comment 11

a year ago
Comment on attachment 8946155 [details]
Bug 1433655 - Allow JSON Viewer to change expandedNodes state.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1417039 
[User impact if declined]: sometimes the JSON Viewer may not expand nodes automatically.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: I have manually verified in Nightly
[Needs manual test from QE? If yes, steps to reproduce]: run the PHP code from comment 8 in a web server and wait until it finishes loading. All nodes should be expanded.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: Not risky
[Why is the change risky/not risky?]: it just tells React to use the updateable state.expandedNodes instead of the initial props.expandedNodes
[String changes made/needed]: None
Attachment #8946155 - Flags: approval-mozilla-beta?
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Comment on attachment 8946155 [details]
Bug 1433655 - Allow JSON Viewer to change expandedNodes state.

Simple fix and verified on Nightly, approving for 59b8.
Attachment #8946155 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I have reproduced this issue using Firefox 60.0a1(2018.01.27) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 59.0b8 and on 60.0a1 (2018.02.09) on Win 8.1 x64, Ubuntu 14.04 x64 and Mac OS X 10.13.3.

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.