1433655 - JSON Viewer may not expand nodes

Status: VERIFIED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[Oriol Brufau [:Oriol]]

1. Enable e10s
2. Load https://bug1394094.bmoattachments.org/attachment.cgi?id=8901438
3. You may need to reload the page a few times

Result: all the JSON is collapsed
Expected: it should be expanded

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a5fce9a1e5c1479514f0a6dc721f07292056f843&tochange=8b81d2b60acf8a95f0773bf7823ec6e0e9da82a3

Comment 3

[Oriol Brufau [:Oriol]]

Attachment: Bug 1433655 - Allow JSON Viewer to change expandedNodes state.

Review commit: https://reviewboard.mozilla.org/r/216144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216144/

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: jsonv.png

(In reply to Oriol Brufau [:Oriol] from comment #0)
> 1. Enable e10s
> 2. Load https://bug1394094.bmoattachments.org/attachment.cgi?id=8901438
> 3. You may need to reload the page a few times
I can't reproduce the problem.

I am attaching a screenshot showing what I am seeing after step #3.
The JSON view looks correctly expanded, right?

Honza

Comment 5

[Oriol Brufau [:Oriol]]

OK, a more reliable way to reproduce is

<?php
header('Content-type: application/json');
$i = 0;
echo "[\n";
while($i < 10) {
  ++$i;
  echo "    [", $i, "],\n";
  ob_end_flush();
  flush();
  ob_start();
  sleep(1);
}
echo "  0\n]";
?>

You said in bug 1417039 comment 10 that you had to disable compression.

Comment 6

[Oriol Brufau [:Oriol]]

You can also only add the test changes from my patch, and it will fail. Also add `await new Promise(() => {})` if you want to have time to check manually that the array is collapsed.

Comment 7

[Intermittent Failures Robot]

2 failures in 735 pushes (0.003 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 1
* autoland: 1

Platform breakdown:
* windows10-64-ccov: 1
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433655&startday=2018-01-29&endday=2018-02-04&tree=all

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8946155 [details]
Bug 1433655 - Allow JSON Viewer to change expandedNodes state.

https://reviewboard.mozilla.org/r/216144/#review223870

Looks good, thanks!

R+ assuming try is green.


Note that I had to use the following code to test the patch:
(ob_start() called at the beggining)

<?php
header('Content-type: application/json');
$i = 0;
echo "[\n";
ob_start();
while($i < 10) {
  ++$i;
  echo "    [", $i, "],\n";
  ob_end_flush();
  flush();
  sleep(1);
}
echo "  0\n]";
?>


Honza

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36a5a69f4328
Allow JSON Viewer to change expandedNodes state. r=Honza

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/36a5a69f4328

Comment 11

[Oriol Brufau [:Oriol]]

Comment on attachment 8946155 [details]
Bug 1433655 - Allow JSON Viewer to change expandedNodes state.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1417039 
[User impact if declined]: sometimes the JSON Viewer may not expand nodes automatically.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: I have manually verified in Nightly
[Needs manual test from QE? If yes, steps to reproduce]: run the PHP code from comment 8 in a web server and wait until it finishes loading. All nodes should be expanded.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: Not risky
[Why is the change risky/not risky?]: it just tells React to use the updateable state.expandedNodes instead of the initial props.expandedNodes
[String changes made/needed]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8946155 [details]
Bug 1433655 - Allow JSON Viewer to change expandedNodes state.

Simple fix and verified on Nightly, approving for 59b8.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/cd07ba84f98d

Comment 14

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 60.0a1(2018.01.27) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 59.0b8 and on 60.0a1 (2018.02.09) on Win 8.1 x64, Ubuntu 14.04 x64 and Mac OS X 10.13.3.