Closed Bug 1433715 Opened 2 years ago Closed 2 years ago

Folder icons not displayed when browsing the file system

Categories

(Firefox for Android :: Theme and Visual Design, defect)

Firefox 57
All
Android
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox58 --- wontfix
firefox59 --- verified
firefox60 --- verified

People

(Reporter: JanH, Assigned: JanH)

References

Details

(Keywords: regression)

Attachments

(1 file)

Assignee: nobody → jh+bugzilla
Attachment #8946157 - Flags: review?(bzbarsky) → review?(gijskruitbosch+bugs)
Comment on attachment 8946157 [details]
Bug 1433715 - Make fallback folder icon content-accessible.

https://reviewboard.mozilla.org/r/216148/#review222648

r=me
Attachment #8946157 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/2703a2d5b196
Make fallback folder icon content-accessible. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/2703a2d5b196
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/173984b4516a
Port bug 1433715 to TB/IB/SM: remove @RESPATH@/res/html/* from package manifests. rs=bustage-fix
Please request Beta approval on this when you get a chance.
Flags: needinfo?(jh+bugzilla)
Comment on attachment 8946157 [details]
Bug 1433715 - Make fallback folder icon content-accessible.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 863246
[User impact if declined]: Folder icons aren't displayed when browsing the file system on Android.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Just moving the icon file to content-accessible, which is the same procedure that had already been done for a few CSS files in the original patch from bug 863246.
[String changes made/needed]: none
Flags: needinfo?(jh+bugzilla)
Attachment #8946157 - Flags: approval-mozilla-beta?
Comment on attachment 8946157 [details]
Bug 1433715 - Make fallback folder icon content-accessible.

Low-risk fix. Approved for 59b7.
Attachment #8946157 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on both Nightly and Latest beta 59.0b9 builds on an Huawei P8 Lite Android 6.0 and on a Pixel XL Android 8.0.0
You need to log in before you can comment on or make changes to this bug.