Closed
Bug 1433715
Opened 7 years ago
Closed 7 years ago
Folder icons not displayed when browsing the file system
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox58 wontfix, firefox59 verified, firefox60 verified)
RESOLVED
FIXED
Firefox 60
People
(Reporter: JanH, Assigned: JanH)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
Gijs
:
review+
RyanVM
:
approval-mozilla-beta+
|
Details |
Mozregression result: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=40bc1d4ce54b34b3851d52576e1b16f68af3bd48&tochange=bd9c5474a5e4e6391a3ae74574885d1361599184
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jh+bugzilla
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Attachment #8946157 -
Flags: review?(bzbarsky) → review?(gijskruitbosch+bugs)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8946157 [details] Bug 1433715 - Make fallback folder icon content-accessible. https://reviewboard.mozilla.org/r/216148/#review222648 r=me
Attachment #8946157 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/2703a2d5b196 Make fallback folder icon content-accessible. r=Gijs
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2703a2d5b196
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/173984b4516a Port bug 1433715 to TB/IB/SM: remove @RESPATH@/res/html/* from package manifests. rs=bustage-fix
|
|
Assignee | |
Comment 7•7 years ago
|
||
Comment on attachment 8946157 [details] Bug 1433715 - Make fallback folder icon content-accessible. Approval Request Comment [Feature/Bug causing the regression]: Bug 863246 [User impact if declined]: Folder icons aren't displayed when browsing the file system on Android. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: No. [Why is the change risky/not risky?]: Just moving the icon file to content-accessible, which is the same procedure that had already been done for a few CSS files in the original patch from bug 863246. [String changes made/needed]: none
Flags: needinfo?(jh+bugzilla)
Attachment #8946157 -
Flags: approval-mozilla-beta?
|
||
Comment 8•7 years ago
|
||
Comment on attachment 8946157 [details] Bug 1433715 - Make fallback folder icon content-accessible. Low-risk fix. Approved for 59b7.
Attachment #8946157 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 9•7 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/711b8a407ffd https://hg.mozilla.org/releases/comm-beta/rev/dab56085762a9bf0e911bf656a314adfd0ba50c8
|
||
Comment 10•7 years ago
|
||
Verified as fixed on both Nightly and Latest beta 59.0b9 builds on an Huawei P8 Lite Android 6.0 and on a Pixel XL Android 8.0.0
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•