1433715 - Folder icons not displayed when browsing the file system

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Jan Henning [:JanH]]

Mozregression result:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=40bc1d4ce54b34b3851d52576e1b16f68af3bd48&tochange=bd9c5474a5e4e6391a3ae74574885d1361599184

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1433715 - Make fallback folder icon content-accessible.

The skin used on Firefox for Android doesn't style directory listing, hence we
fall back to using the default icon from gre/res/html. As of bug 863246, this
location is no longer accessible from content as a resource://, hence the file
needs moving into the special content-accessible directory.

Review commit: https://reviewboard.mozilla.org/r/216148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216148/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8946157 [details]
Bug 1433715 - Make fallback folder icon content-accessible.

https://reviewboard.mozilla.org/r/216148/#review222648

r=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2703a2d5b196
Make fallback folder icon content-accessible. r=Gijs

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2703a2d5b196

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/173984b4516a
Port bug 1433715 to TB/IB/SM: remove @RESPATH@/res/html/* from package manifests. rs=bustage-fix

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 7

[Jan Henning [:JanH]]

Comment on attachment 8946157 [details]
Bug 1433715 - Make fallback folder icon content-accessible.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 863246
[User impact if declined]: Folder icons aren't displayed when browsing the file system on Android.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Just moving the icon file to content-accessible, which is the same procedure that had already been done for a few CSS files in the original patch from bug 863246.
[String changes made/needed]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8946157 [details]
Bug 1433715 - Make fallback folder icon content-accessible.

Low-risk fix. Approved for 59b7.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/711b8a407ffd
https://hg.mozilla.org/releases/comm-beta/rev/dab56085762a9bf0e911bf656a314adfd0ba50c8

Comment 10

[u549602]

Verified as fixed on both Nightly and Latest beta 59.0b9 builds on an Huawei P8 Lite Android 6.0 and on a Pixel XL Android 8.0.0