Closed Bug 143375 Opened 24 years ago Closed 24 years ago

possible duplicate variable assign code gfx/src/gtk/nsFontMetricsGTK

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
minor

Tracking

()

RESOLVED INVALID

People

(Reporter: mike, Assigned: bstell)

Details

static void 4100 FFREToXLFDPattern(nsACString &aFFREName, nsACString &oPattern) 4101 { 4102 oPattern.Append("-"); 4103 oPattern.Append(aFFREName); 4104 PRInt32 charsetHyphen = oPattern.FindChar('-'); 4105 charsetHyphen = oPattern.FindChar('-', charsetHyphen + 1); <-- 4106 charsetHyphen = oPattern.FindChar('-', charsetHyphen + 1); <-- 4107 oPattern.Insert("-*-*-*-*-*-*-*-*-*-*", charsetHyphen); 4108 }
->bstell
Assignee: Matti → bstell
Status: UNCONFIRMED → NEW
Component: Browser-General → Layout
Ever confirmed: true
4104 PRInt32 charsetHyphen = oPattern.FindChar('-'); 4105 charsetHyphen = oPattern.FindChar('-', charsetHyphen + 1); <-- 4106 charsetHyphen = oPattern.FindChar('-', charsetHyphen + 1); <-- Welcome to mozilla string functions and their (il)logic. The first line, 4104, finds the first hyphen. The second line, 4105, finds the second hyphen. The third line, 4106, finds the third hyphen. Removing either the second or third line would break this function.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.