143379 - Build Bustage: patch for bug 124042 broke solrais's build

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Jay Yan]

patch for bug 124042 broke solaris's build

compiling err happen when do release build on Solrais using Forte's CC, 

it is the configuration:

./configure --enable-default-toolkit=gtk2 --enable-optimize --disable-debug --
disable-tests --with-xprint --enable-xinerama --enable-ldap --enable-x11-shm 
--disable-auto-deps --enable-crypto --enable-strip-libs;

it is the information of compiling error.


------------------------------------------------------------------
CC: Warning: -O overwrites previously set optimization level of -O3
"inBitmapURI.cpp", line 97: Error: Formal argument aSearchStart of type 
nsReadingIterator<char>& in call to FindCharInReadable(char, 
nsReadingIterator<char>&, const nsReadingIterator<char>&) requires an 
lvalue.
1 Error(s) detected.
gmake[5]: *** [inBitmapURI.o] Error 1
gmake[5]: Leaving directory 
`/export/admin/build/mozilla1.0/mozilla/extensions/inspector/base/src'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory 
`/export/admin/build/mozilla1.0/mozilla/extensions/inspector/base'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory 
`/export/admin/build/mozilla1.0/mozilla/extensions/inspector'
gmake[2]: *** [libs] Error 2
gmake[2]: Leaving directory 
`/export/admin/build/mozilla1.0/mozilla/extensions'
gmake[1]: *** [tier_94] Error 2
gmake[1]: Leaving directory `/export/admin/build/mozilla1.0/mozilla'
gmake: *** [default] Error 2
----------------------------------

Comment 1

[Jay Yan]

Becasue we are going to test mozilla(gtk2) on Solaris, so I tried to build
mozilla(gtk2) on Solaris, I met woth this problem.

Then I tried to build mozilla with gtk on Solaris, it also broken.

Comment 2

[Jay Yan]

Attachment: patch

after I apply this to my workspace, the building become successful.

It seems that it is a bug of Forte's CC, but can we check this patch in at
first in order that our mozilla(gtk2) test work can go on?

Comment 3

[Jay Yan]

I will own this bug, can anybody r= ? thanks

Comment 4

[Darin Fisher]

Comment on attachment 83002 [details] [diff] [review]
patch

sr=darin

Comment 5

[Christopher Blizzard (:blizzard)]

Comment on attachment 83002 [details] [diff] [review]
patch

r=blizzard

Comment 6

[Jay Yan]

sorry for my absense because of a 2day training, I will check it in today.
thanks all
Jay

Comment 7

[Jay Yan]

checked in

Comment 8

[Jay Yan]

and we will identify where the real bug is, if it is compiler's bug, we will
file bug against the compiler.
Margaret, thanks for reminding.

Comment 9

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword. 

Comment 10

[Jay Yan]

checked in 1.0 branch

Comment 11

[benc]

Can someone using Solaris (or someone from Sun), confirm this is fixed?

If so, please set STATUS=VERIFIED, and change the "fixed1.0.1" keyword to
"verified1.0.1".

Comment 12

[Jay Yan]

verified