Closed Bug 1433869 Opened 2 years ago Closed 2 years ago

Don't default CSD mode for release/beta builds and unknown WM/DE

Categories

(Core :: Widget: Gtk, defect, P2)

60 Branch
x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox59 --- fixed
firefox60 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Recently we use default CSD mode for unknown/untested window managers. We should disable this default for release/beta builds to keep user experience on those systems.
Depends on: 1432385
Comment on attachment 8946210 [details]
Bug 1433869 - Disable CSD titlebar mode on untested/unknown systems for Release/Beta,

https://reviewboard.mozilla.org/r/216184/#review222016

Sounds reasonable to me.
Attachment #8946210 - Flags: review?(jhorak) → review+
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/4a70ce5756cc
Disable CSD titlebar mode on untested/unknown systems for Release/Beta, r=jhorak
https://hg.mozilla.org/mozilla-central/rev/4a70ce5756cc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment on attachment 8946210 [details]
Bug 1433869 - Disable CSD titlebar mode on untested/unknown systems for Release/Beta,

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: CSD/Titlebar rendering will be available on untested DE/WM systems and could cause bad user experience when CSD/Titlebar is enabled by user. User may not be able to move/resize Firefox window.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: Not applicable - we want to disable untested systems for Beta/Release only.
[Needs manual test from QE? If yes, steps to reproduce]: None
[List of other uplifts needed for the feature/fix]: Bug 1432385
[Is the change risky?]: no
[Why is the change risky/not risky?]: Not risky - it only disables CSD/Titlebar feature on untested systems which means the main Firefox window will have default titlebar/resize borders there.
[String changes made/needed]: none
Attachment #8946210 - Flags: approval-mozilla-beta?
Comment on attachment 8946210 [details]
Bug 1433869 - Disable CSD titlebar mode on untested/unknown systems for Release/Beta,

low risk, disabling on untested systems makes sense, Beta59+
Attachment #8946210 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.