1433869 - Don't default CSD mode for release/beta builds and unknown WM/DE

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Recently we use default CSD mode for unknown/untested window managers. We should disable this default for release/beta builds to keep user experience on those systems.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1433869 - Disable CSD titlebar mode on untested/unknown systems for Release/Beta,

Review commit: https://reviewboard.mozilla.org/r/216184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216184/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8946210 [details]
Bug 1433869 - Disable CSD titlebar mode on untested/unknown systems for Release/Beta,

https://reviewboard.mozilla.org/r/216184/#review222016

Sounds reasonable to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a70ce5756cc
Disable CSD titlebar mode on untested/unknown systems for Release/Beta, r=jhorak

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4a70ce5756cc

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8946210 [details]
Bug 1433869 - Disable CSD titlebar mode on untested/unknown systems for Release/Beta,

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: CSD/Titlebar rendering will be available on untested DE/WM systems and could cause bad user experience when CSD/Titlebar is enabled by user. User may not be able to move/resize Firefox window.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: Not applicable - we want to disable untested systems for Beta/Release only.
[Needs manual test from QE? If yes, steps to reproduce]: None
[List of other uplifts needed for the feature/fix]: Bug 1432385
[Is the change risky?]: no
[Why is the change risky/not risky?]: Not risky - it only disables CSD/Titlebar feature on untested systems which means the main Firefox window will have default titlebar/resize borders there.
[String changes made/needed]: none

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8946210 [details]
Bug 1433869 - Disable CSD titlebar mode on untested/unknown systems for Release/Beta,

low risk, disabling on untested systems makes sense, Beta59+

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/cb55e5e2cdd5