TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_nonascii_path.js - Windows Buildbot only (8.3 names enabled)

RESOLVED FIXED in Firefox 60

Status

()

defect
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [Thunderbird-testfailure: X Windows only])

Attachments

(1 attachment)

Assignee

Description

a year ago
TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_nonascii_path.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_nonascii_path.js | undefined assertion name - the profile short path should contain a non-ASCII character - false == true

First seen: Sun Jan 28, 2018, 11:55:03

M-C last good: 2507af6c97edc2cce3448698a9f9a77cd9
M-C first bad: 094915903938edc416a0de3b069f5d4a06

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2507af6c97edc2cce3448698a9f9a77cd9&tochange=094915903938edc416a0de3b069f5d4a06

This is a Windows-only failure. I suspect bug 685236. I'm not sure why this test would fail in the Thunderbird Xpcshell test run, but not for Firefox.

I'd have to refresh my local build to see what's going on. The log
https://archive.mozilla.org/pub/thunderbird/nightly/2018/01/2018-01-28-03-02-01-comm-central/comm-central_win7_ix_test-xpcshell-bm111-tests1-windows-build184.txt.gz
says:
TEST-PASS | security/manager/ssl/tests/unit/test_nonascii_path.js | undefined assertion name - the profile path should contain a non-ASCII character - true == true
TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_nonascii_path.js | undefined assertion name - the profile short path should contain a non-ASCII character - false == true

So the profile path is OK, that short path is not. That second test only runs on Windows:
file = do_get_profile(); // must be called before getting nsIX509CertDB
Assert.ok(/[^\x20-\x7f]/.test(file.path), "the profile path should contain a non-ASCII character");
if (mozinfo.os == "win") {
  file.QueryInterface(Components.interfaces.nsILocalFileWin);
  Assert.ok(/[^\x20-\x7f]/.test(file.canonicalPath), "the profile short path should contain a non-ASCII character");
}

Masatoshi-san, could you please take a look.
Flags: needinfo?(VYV03354)
Assignee

Updated

a year ago
Whiteboard: [Thunderbird-testfailure: X Windows only]
The last good log does not contain test_nonascii_path.js yet:
https://archive.mozilla.org/pub/thunderbird/nightly/2018/01/2018-01-27-03-02-01-comm-central/comm-central_win7_ix_test-xpcshell-bm111-tests1-windows-build181.txt.gz

So this test have never succeeded on Tb runs since bug 1430973 landed. I guess Tb builders are not disabling 8dot3name creation.
Can you change the automation setting to disable 8dot3name creation? (FYI bug 946464 is the corresponding Firefox bug.) If not, you can make the failing check todo only on Tb runs.
Blocks: 1430973
Flags: needinfo?(VYV03354)
(In reply to Masatoshi Kimura [:emk] from comment #1)
> If not, you can make the failing check todo only on Tb runs.

For example:
```
  if (AppConstants.MOZ_APP_NAME == "thunderbird") {
    Assert.ok(!/[^\x20-\x7f]/.test(file.canonicalPath), "todo: the profile short path will only have ASCII characters on Thunderbird builders, because 8dot3name are not disabled");
  } else {
    Assert.ok(/[^\x20-\x7f]/.test(file.canonicalPath), "the profile short path should contain a non-ASCII character");
  }
```
Assignee

Comment 3

a year ago
Thanks for the quick reply.

(In reply to Masatoshi Kimura [:emk] from comment #1)
> The last good log does not contain test_nonascii_path.js yet:
> https://archive.mozilla.org/pub/thunderbird/nightly/2018/01/2018-01-27-03-02-
> 01-comm-central/comm-central_win7_ix_test-xpcshell-bm111-tests1-windows-
> build181.txt.gz
> 
> So this test have never succeeded on Tb runs since bug 1430973 landed.
Correct, this is a new test.

> I guess Tb builders are not disabling 8dot3name creation.
> Can you change the automation setting to disable 8dot3name creation? (FYI
> bug 946464 is the corresponding Firefox bug.) If not, you can make the
> failing check todo only on Tb runs.
We'd have to ask out build engineer Tom about the 8.3 stuff on buildbot. The TaskCluster builds are currently not working, so we can't see whether the test passes there. It maybe that Buildbot machines have 8.3 enabled and TC machines don't. In this case we should just skip the test altogether.

As for 8.3 in general: Remember bug 1304183, it turned out that 8.3 filenames were required or else mt.exe wasn't found. And then there is bug 1323381 which shows that 8.3 is required. So I'm a bit surprised that you say that it can be switched off.

Tom, what do you know about 8.3 on Windows build machines?
Flags: needinfo?(mozilla)
Bug 1304183 and 1323381 are unaffected maybe because automation installs build tools under custom short paths that do not contain a space.
(In reply to Jorg K (GMT+1) from comment #3)
> It maybe that Buildbot machines have 8.3 enabled and TC
> machines don't. In this case we should just skip the test altogether.

Even if 8.3 name creation is enabled, this test still catches some regressions regarding non-ASCII paths. So I would not like to simply disable the entire test.
Assignee

Comment 6

a year ago
(In reply to Masatoshi Kimura [:emk] from comment #5)
> Even if 8.3 name creation is enabled, this test still catches some
> regressions regarding non-ASCII paths. So I would not like to simply disable
> the entire test.
Sorry, this was a misunderstanding. I'd just skip this

if (mozinfo.os == "win") {
  file.QueryInterface(Components.interfaces.nsILocalFileWin);
  Assert.ok(/[^\x20-\x7f]/.test(file.canonicalPath), "the profile short path should contain a non-ASCII character");
}

for TB.

The test doesn't fail on the TaskCluster runs on Windows 10 but it fails on the Buildbot runs on Windows 7. But let's hear from Tom first.
Assignee

Updated

a year ago
Summary: TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_nonascii_path.js - Windows only → TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_nonascii_path.js - Windows Buildbot only (8.3 names enabled)
Assignee

Comment 7

a year ago
This should do it. TB will fully move to TaskCluster after TB 60.

I talked to our build/release engineer Tom. He prefers not to mess with the Buildbot configuration or the builders.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Flags: needinfo?(mozilla)
Attachment #8946452 - Flags: review?(VYV03354)
Comment on attachment 8946452 [details] [diff] [review]
1433903-partly-skip-test_nonascii_path.patch

Review of attachment 8946452 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/tests/unit/test_nonascii_path.js
@@ +19,5 @@
>  
>  file = do_get_profile(); // must be called before getting nsIX509CertDB
>  Assert.ok(/[^\x20-\x7f]/.test(file.path), "the profile path should contain a non-ASCII character");
> +// Due to 8.3 names being enabled on Thunderbird's Buildbot, this will fail. It passes
> +// on TaskCluster, so this check can be removed when Buildbot is dropped.

Please file a follow-up bug to track the removal of this workaround when TB moved to TaskCluster.
Attachment #8946452 - Flags: review?(VYV03354) → review+
Assignee

Comment 9

a year ago
Thanks for the review.

(In reply to Masatoshi Kimura [:emk] from comment #8)
> Please file a follow-up bug to track the removal of this workaround when TB
> moved to TaskCluster.
Will do once this has landed so I can refer to the exact line we need to revert.
Component: Testing Infrastructure → Security: PSM
Keywords: checkin-needed
Product: Thunderbird → Core

Comment 10

a year ago
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b76a1f5e05dc
Skip parts of test_nonascii_path.js for Thunderbird. r=emk
Keywords: checkin-needed

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b76a1f5e05dc
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee

Updated

a year ago
Blocks: 1434567
Depends on: 1440558
You need to log in before you can comment on or make changes to this bug.