Closed
Bug 1433932
Opened 6 years ago
Closed 6 years ago
Webrender Capture instantly crashes entire browser when nightly is installed somewhere non-writeable
Categories
(Core :: Graphics: WebRender, defect, P2)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Gankra, Assigned: kvark)
References
Details
Crash Data
Attachments
(1 file)
|
1.58 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
I have nightly installed like any normal application in MacOS: in /Applications/
when I try to run the capture system (CTRL+SHIFT+3) the whole browser crashes. The crash report contains
called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 13, message: "Permission denied" } }
indicating the destination of the log wasn't writeable.
We should
A) handle this error more gracefully (fail silently?)
B) find a way to write the log in this situation
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Crash Signature: [@ core::result::unwrap_failed<T> | webrender::render_backend::RenderBackend::save_capture]
|
|
||
Updated•6 years ago
|
Crash Signature: [@ core::result::unwrap_failed<T> | webrender::render_backend::RenderBackend::save_capture] → [@ core::result::unwrap_failed<T> | webrender::render_backend::RenderBackend::save_capture]
[@ mozalloc_abort | abort | core::result::unwrap_failed<T> | webrender_bindings::bindings::wr_api_capture]
|
Assignee | |
Comment 4•6 years ago
|
||
Kats, at the end of the day we'd want to make the capture path configurable (with a pref as the simplest solution). For now it's not that important, since it's relatively easy to workaround, and we haven't gone through the first round of dog-fooding.
Flags: needinfo?(kvark)
|
|
||
Comment 5•6 years ago
|
||
Well, having our nightly users crash because of this key combo is less than ideal. We should at least stop the crashing ASAP even if we don't have a full fix for the problem.
|
|
Assignee | |
Comment 6•6 years ago
|
||
The patch attempts to write down the revision into `wr.txt` before saving the capture, and gracefully exists if that fails. Alexei - would be awesome if you could check it out and confirm if it helps.
Assignee: nobody → kvark
Status: NEW → ASSIGNED
Attachment #8949363 -
Flags: review?(bugmail)
Attachment #8949363 -
Flags: feedback?(a.beingessner)
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 8949363 [details] [diff] [review] capture-crash.patch Review of attachment 8949363 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me (and for posterity nical also r+'d these changes at bug 1436190)
Attachment #8949363 -
Flags: review?(bugmail) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c20c8479be29 Avoid crashing on failing to save a capture. r=nical,kats
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c20c8479be29
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
Reporter | |
Updated•6 years ago
|
Attachment #8949363 -
Flags: feedback?(a.beingessner)
You need to log in
before you can comment on or make changes to this bug.
Description
•